Bug 1550334

Looks good.

BTW, after fixing issues in rawhide, we should work on porting these spec files to EPEL, and push pgadmin4 there as well.

new version ->

https://itamarjp.fedorapeople.org/review/python-pyrsistent.spec
https://itamarjp.fedorapeople.org/review/python-pyrsistent-0.14.2-1.src.rpm

 - You need to run the tests from upstream and build the sphinx docs.

 - Also:

Requires: python2-six

   Shouldn't that be a BR like the Python3 package.

 - Not needed:

Group:

theres no sphinx docs, the docs are on README / README.RST

There's a Makefile to build the sphinx doc https://github.com/tobgu/pyrsistent/blob/master/docs/Makefile

(In reply to Robert-André Mauchin from comment #5)
> There's a Makefile to build the sphinx doc
> https://github.com/tobgu/pyrsistent/blob/master/docs/Makefile

I am interested in less work possible, also I am using the source code that comes from pypi, you can download it and unpack and there's no docs/Makefile on it :-)


https://pypi.python.org/pypi/pyrsistent

README file are being shipped as doc, I think is enough,

Spec URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent.spec

SRPM URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent-0.14.2-1.src.rpm

 - You must install LICENSE.mit with %license in %files

 - Simplify %files:

%files  -n python2-%{srcname}
%license LICENSE.mit
%doc README.rst
%{python2_sitearch}/%{srcname}
%{python2_sitearch}/_%{srcname}_version.py*
%{python2_sitearch}/p*.so
%{python2_sitearch}/%{srcname}-%{version}-py?.?.egg-info/*

%files -n python%{python3_pkgversion}-%{srcname}
%license LICENSE.mit
%doc README.rst
%{python3_sitearch}/__pycache__/_%{srcname}_*.pyc
%{python3_sitearch}/_%{srcname}_version.py
%{python3_sitearch}/%{srcname}
%{python3_sitearch}/%{srcname}-%{version}-py?.?.egg-info/*
%{python3_sitearch}/pvectorc.cpython*.so


 - Run the provided tests

Spec URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent.spec

SRPM URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent-0.14.2-2.src.rpm

 - I can't run the tests in mock, did you forget to add some BuildRequires?


gcc -pthread -shared -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld build/temp.linux-x86_64-2.7/pvectorcmodule.o -L/usr/lib64 -lpython2.7 -o /builddir/build/BUILD/pyrsistent-0.14.2/pvectorc.so
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File "setup.py", line 85, in <module>
BUILDSTDERR:     packages=['pyrsistent']
BUILDSTDERR:   File "/usr/lib/python2.7/site-packages/setuptools/__init__.py", line 129, in setup
BUILDSTDERR:     return distutils.core.setup(**attrs)
BUILDSTDERR:   File "/usr/lib64/python2.7/distutils/core.py", line 151, in setup
BUILDSTDERR:     dist.run_commands()
BUILDSTDERR:   File "/usr/lib64/python2.7/distutils/dist.py", line 953, in run_commands
BUILDSTDERR:     self.run_command(cmd)
BUILDSTDERR:   File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
BUILDSTDERR:     cmd_obj.run()
BUILDSTDERR:   File "/usr/lib/python2.7/site-packages/setuptools/command/test.py", line 226, in run
BUILDSTDERR:     self.run_tests()
BUILDSTDERR:   File "/usr/lib/python2.7/site-packages/setuptools/command/test.py", line 248, in run_tests
BUILDSTDERR:     exit=False,
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/main.py", line 94, in __init__
BUILDSTDERR:     self.parseArgs(argv)
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/main.py", line 149, in parseArgs
BUILDSTDERR:     self.createTests()
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/main.py", line 158, in createTests
BUILDSTDERR:     self.module)
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
BUILDSTDERR:     suites = [self.loadTestsFromName(name, module) for name in names]
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/loader.py", line 91, in loadTestsFromName
BUILDSTDERR:     module = __import__('.'.join(parts_copy))
BUILDSTDERR: ImportError: No module named tests

on my machine rpkg.noarch 0.14-1.fc28 has a tests/__init__.py 

and python2 tests finishes, there's something broken in the tests.

without tests.


Spec URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent.spec

SRPM URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent-0.14.2-2.src.rpm

Package approved but see with upstream about the failing tests.

$ fedpkg --module-name python-pyrsistent request-repo 1550334
https://pagure.io/releng/fedora-scm-requests/issue/5946


$ fedpkg --module-name python-pyrsistent request-branch f27
https://pagure.io/releng/fedora-scm-requests/issue/5947

$ fedpkg --module-name python-pyrsistent request-branch f28
https://pagure.io/releng/fedora-scm-requests/issue/5948

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyrsistent

python-pyrsistent-0.14.2-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-004c7dae72

python-pyrsistent-0.14.2-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bfc80b2956

python-pyrsistent-0.14.2-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

python-pyrsistent-0.14.2-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.