Bug 1550334 - Review Request: python-pyrsistent - Persistent/Functional/Immutable data structures
Summary: Review Request: python-pyrsistent - Persistent/Functional/Immutable data str...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1380826
TreeView+ depends on / blocked
 
Reported: 2018-03-01 03:12 UTC by Itamar Reis Peixoto
Modified: 2018-04-27 04:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-18 01:24:14 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Itamar Reis Peixoto 2018-03-01 03:12:00 UTC
Spec URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent.spec
SRPM URL: https://itamarjp.fedorapeople.org/review/python-pyrsistent-0.11.13-3.src.rpm

Description: Persistent/Functional/Immutable data structures

Fedora Account System Username:itamarjp

Comment 1 Devrim Gündüz 2018-03-01 11:41:56 UTC
Looks good.

BTW, after fixing issues in rawhide, we should work on porting these spec files to EPEL, and push pgadmin4 there as well.

Comment 3 Robert-André Mauchin 🐧 2018-03-02 14:28:12 UTC
 - You need to run the tests from upstream and build the sphinx docs.

 - Also:

Requires: python2-six

   Shouldn't that be a BR like the Python3 package.

 - Not needed:

Group:

Comment 4 Itamar Reis Peixoto 2018-03-02 14:41:09 UTC
theres no sphinx docs, the docs are on README / README.RST

Comment 5 Robert-André Mauchin 🐧 2018-03-02 14:46:24 UTC
There's a Makefile to build the sphinx doc https://github.com/tobgu/pyrsistent/blob/master/docs/Makefile

Comment 6 Itamar Reis Peixoto 2018-03-02 20:46:29 UTC
(In reply to Robert-André Mauchin from comment #5)
> There's a Makefile to build the sphinx doc
> https://github.com/tobgu/pyrsistent/blob/master/docs/Makefile

I am interested in less work possible, also I am using the source code that comes from pypi, you can download it and unpack and there's no docs/Makefile on it :-)


https://pypi.python.org/pypi/pyrsistent

README file are being shipped as doc, I think is enough,

Comment 8 Robert-André Mauchin 🐧 2018-04-13 22:36:21 UTC
 - You must install LICENSE.mit with %license in %files

 - Simplify %files:

%files  -n python2-%{srcname}
%license LICENSE.mit
%doc README.rst
%{python2_sitearch}/%{srcname}
%{python2_sitearch}/_%{srcname}_version.py*
%{python2_sitearch}/p*.so
%{python2_sitearch}/%{srcname}-%{version}-py?.?.egg-info/*

%files -n python%{python3_pkgversion}-%{srcname}
%license LICENSE.mit
%doc README.rst
%{python3_sitearch}/__pycache__/_%{srcname}_*.pyc
%{python3_sitearch}/_%{srcname}_version.py
%{python3_sitearch}/%{srcname}
%{python3_sitearch}/%{srcname}-%{version}-py?.?.egg-info/*
%{python3_sitearch}/pvectorc.cpython*.so


 - Run the provided tests

Comment 10 Robert-André Mauchin 🐧 2018-04-13 23:57:55 UTC
 - I can't run the tests in mock, did you forget to add some BuildRequires?


gcc -pthread -shared -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld build/temp.linux-x86_64-2.7/pvectorcmodule.o -L/usr/lib64 -lpython2.7 -o /builddir/build/BUILD/pyrsistent-0.14.2/pvectorc.so
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File "setup.py", line 85, in <module>
BUILDSTDERR:     packages=['pyrsistent']
BUILDSTDERR:   File "/usr/lib/python2.7/site-packages/setuptools/__init__.py", line 129, in setup
BUILDSTDERR:     return distutils.core.setup(**attrs)
BUILDSTDERR:   File "/usr/lib64/python2.7/distutils/core.py", line 151, in setup
BUILDSTDERR:     dist.run_commands()
BUILDSTDERR:   File "/usr/lib64/python2.7/distutils/dist.py", line 953, in run_commands
BUILDSTDERR:     self.run_command(cmd)
BUILDSTDERR:   File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
BUILDSTDERR:     cmd_obj.run()
BUILDSTDERR:   File "/usr/lib/python2.7/site-packages/setuptools/command/test.py", line 226, in run
BUILDSTDERR:     self.run_tests()
BUILDSTDERR:   File "/usr/lib/python2.7/site-packages/setuptools/command/test.py", line 248, in run_tests
BUILDSTDERR:     exit=False,
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/main.py", line 94, in __init__
BUILDSTDERR:     self.parseArgs(argv)
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/main.py", line 149, in parseArgs
BUILDSTDERR:     self.createTests()
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/main.py", line 158, in createTests
BUILDSTDERR:     self.module)
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
BUILDSTDERR:     suites = [self.loadTestsFromName(name, module) for name in names]
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/loader.py", line 91, in loadTestsFromName
BUILDSTDERR:     module = __import__('.'.join(parts_copy))
BUILDSTDERR: ImportError: No module named tests

Comment 11 Itamar Reis Peixoto 2018-04-14 01:35:35 UTC
on my machine rpkg.noarch 0.14-1.fc28 has a tests/__init__.py 

and python2 tests finishes, there's something broken in the tests.

Comment 13 Robert-André Mauchin 🐧 2018-04-14 10:17:36 UTC
Package approved but see with upstream about the failing tests.

Comment 14 Itamar Reis Peixoto 2018-04-14 18:29:16 UTC
$ fedpkg --module-name python-pyrsistent request-repo 1550334
https://pagure.io/releng/fedora-scm-requests/issue/5946


$ fedpkg --module-name python-pyrsistent request-branch f27
https://pagure.io/releng/fedora-scm-requests/issue/5947

$ fedpkg --module-name python-pyrsistent request-branch f28
https://pagure.io/releng/fedora-scm-requests/issue/5948

Comment 15 Gwyn Ciesla 2018-04-16 12:37:40 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyrsistent

Comment 16 Fedora Update System 2018-04-17 00:14:36 UTC
python-pyrsistent-0.14.2-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-004c7dae72

Comment 17 Fedora Update System 2018-04-17 00:14:45 UTC
python-pyrsistent-0.14.2-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bfc80b2956

Comment 18 Fedora Update System 2018-04-18 01:24:14 UTC
python-pyrsistent-0.14.2-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2018-04-27 04:05:14 UTC
python-pyrsistent-0.14.2-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.