Bug 1550743
| Summary: | Review request: open-eid - Meta-package for Estonian Electronic Identity Software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Germano Massullo <germano.massullo> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | klember, package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-24 06:34:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1550740 | ||
| Bug Blocks: | |||
|
Description
Germano Massullo
2018-03-01 23:52:20 UTC
- Obsoletes: estonianidcard You should add the Provides too. See https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages (In reply to Robert-André Mauchin from comment #1) > - Obsoletes: estonianidcard > > You should add the Provides too. See Done https://germano.fedorapeople.org/package_reviews/open-eid/open-eid.spec https://germano.fedorapeople.org/package_reviews/open-eid/open-eid-3.12.0-1.fc27.src.rpm Obsoletes: estonianidcard Provides: estonianidcard You didn't include the version you replace, nor the one you provide instead. https://germano.fedorapeople.org/package_reviews/open-eid/open-eid.spec https://germano.fedorapeople.org/package_reviews/open-eid/open-eid-17.12-1.fc27.src.rpm From what do you derive the version? (In reply to Robert-André Mauchin from comment #5) > From what do you derive the version? Previous maintainer used to get version from ubuntu meta package https://github.com/open-eid/linux-installer but since we don't package the content of https://github.com/open-eid/linux-installer/releases because it is useless to us, I am undecided if continuing using such versioning or not. Depending on this decision we should also think about adding or not https://github.com/open-eid/linux-installer to URL tag Ok, package approved. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/open-eid |