Bug 1550743 - Review request: open-eid - Meta-package for Estonian Electronic Identity Software
Summary: Review request: open-eid - Meta-package for Estonian Electronic Identity Soft...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1550740
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-01 23:52 UTC by Germano Massullo
Modified: 2018-07-24 06:34 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-24 06:34:23 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Germano Massullo 2018-03-01 23:52:20 UTC
open-eid - Meta-package for Estonian Electronic Identity Software

https://germano.fedorapeople.org/package_reviews/open-eid/open-eid.spec

https://germano.fedorapeople.org/package_reviews/open-eid/open-eid-3.12.0-1.fc27.src.rpm

Some of the Requires are in testing repository, another instead is in package review

Comment 1 Robert-André Mauchin 🐧 2018-03-02 14:20:52 UTC
 - Obsoletes:	    estonianidcard

You should add the Provides too. See https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Comment 2 Germano Massullo 2018-03-02 14:48:28 UTC
(In reply to Robert-André Mauchin from comment #1)
>  - Obsoletes:	    estonianidcard
> 
> You should add the Provides too. See

Done

https://germano.fedorapeople.org/package_reviews/open-eid/open-eid.spec

https://germano.fedorapeople.org/package_reviews/open-eid/open-eid-3.12.0-1.fc27.src.rpm

Comment 3 Robert-André Mauchin 🐧 2018-03-02 15:48:34 UTC
Obsoletes:      estonianidcard
Provides:       estonianidcard

You didn't include the version you replace, nor the one you provide instead.

Comment 5 Robert-André Mauchin 🐧 2018-03-02 17:37:53 UTC
From what do you derive the version?

Comment 6 Germano Massullo 2018-03-02 17:45:08 UTC
(In reply to Robert-André Mauchin from comment #5)
> From what do you derive the version?

Previous maintainer used to get version from ubuntu meta package
https://github.com/open-eid/linux-installer
but since we don't package the content of
https://github.com/open-eid/linux-installer/releases
because it is useless to us, I am undecided if continuing using such versioning or not.

Depending on this decision we should also think about adding or not
https://github.com/open-eid/linux-installer
to URL tag

Comment 7 Robert-André Mauchin 🐧 2018-03-02 17:50:40 UTC
Ok, package approved.

Comment 8 Gwyn Ciesla 2018-03-02 17:57:20 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/open-eid


Note You need to log in before you can comment on or make changes to this bug.