Bug 1550988

Summary: gdeploy should stop execution when enabling lvmcache fails
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: SATHEESARAN <sasundar>
Component: rhhiAssignee: Sahina Bose <sabose>
Status: CLOSED ERRATA QA Contact: Mugdha Soni <musoni>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rhhiv-1.5CC: rhs-bugs
Target Milestone: ---   
Target Release: RHHI-V 1.5   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.17-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1550989 (view as bug list) Environment:
Last Closed: 2018-11-08 05:38:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1550989    
Bug Blocks: 1520836    
Attachments:
Description Flags
screenshot of ignore lv error none

Description SATHEESARAN 2018-03-02 13:49:34 UTC 
Description of problem:
------------------------
gdeploy execution should halt when the task of enabling lvmcache fails.

In gdeploy terms - 'ignore_lv_errors' should be set to 'no' under lvmcache enabling section in generated config file

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.11.12-0.1.el7ev.noarch

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Initiate RHHI deployment using cockpit
2. Enable LVMcache
3. Observe the generated gdeploy config file

Actual results:
---------------
'ignore_lv_errors' is set to 'yes'

Expected results:
-----------------
'ignore_lv_errors' should be set to 'no'

Additional info:
----------------
actual snip in gdeploy config file:
[lv5]
action=setup-cache
ssd=sdc
vgname=gluster_vg_sdb
poolname=gluster_thinpool_sdb
cache_lv=lvcache
cache_lvsize=220
cachemode=writethrough
ignore_lv_errors=yes

Expected:
[lv5]
action=setup-cache
ssd=sdc
vgname=gluster_vg_sdb
poolname=gluster_thinpool_sdb
cache_lv=lvcache
cache_lvsize=220
cachemode=writethrough
ignore_lv_errors=no
Comment 1 SATHEESARAN 2018-04-17 10:42:54 UTC 
As the dependent bug is ON_QA, moving this bug to ON_QA
Comment 5 Mugdha Soni 2018-04-17 11:17:52 UTC 
Tested with the following-:

1. RedHat-release-virtualization-host-4.2-2.1.el7.x86_64
2. Cockpit-ovirt-dashboard-0.11.20-1
3. gdeploy-2.0.2-19.el7rhgs.noarch

Following were the steps performed to test:-

1.Log in to the cockpit UI and configure all the parameters required for gluster 
 deployment.

2.In the gdeploy config file there is a presence of parameter 'ignore_lv_errors=no'.

3.The gdeploy execution successfully halts whenever there is a lvmcache error.
Comment 6 Mugdha Soni 2018-04-17 11:18:31 UTC 
Created attachment 1422998 [details]
screenshot of ignore lv error
Comment 8 errata-xmlrpc 2018-11-08 05:38:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:3523