Bug 1550989 - gdeploy should stop execution when enableing lvmcache fails
Summary: gdeploy should stop execution when enableing lvmcache fails
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.11.12
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-4.2.2
: 0.11.17
Assignee: Parth Dhanjal
QA Contact: Mugdha Soni
URL:
Whiteboard:
Depends On:
Blocks: 1550988
TreeView+ depends on / blocked
 
Reported: 2018-03-02 13:51 UTC by SATHEESARAN
Modified: 2018-04-18 12:24 UTC (History)
4 users (show)

Fixed In Version: cockpit-ovirt-0.11.17-1
Clone Of: 1550988
Environment:
Last Closed: 2018-04-18 12:24:49 UTC
oVirt Team: Gluster
Embargoed:
sasundar: ovirt-4.2?
sasundar: planning_ack?
rule-engine: devel_ack+
sasundar: testing_ack+


Attachments (Terms of Use)
screenshot of ignore lv error (97.26 KB, image/png)
2018-04-17 11:03 UTC, Mugdha Soni
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 88957 0 master MERGED Gdeploy stops execution when enabling Lvmcache 2018-03-14 12:28:08 UTC
oVirt gerrit 88991 0 ovirt-4.2 MERGED Gdeploy stops execution when enabling Lvmcache 2018-03-14 12:39:45 UTC

Description SATHEESARAN 2018-03-02 13:51:40 UTC
+++ This bug was initially created as a clone of Bug #1550988 +++

Description of problem:
------------------------
gdeploy execution should halt when the task of enabling lvmcache fails.

In gdeploy terms - 'ignore_lv_errors' should be set to 'no' under lvmcache enabling section in generated config file

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.11.12-0.1.el7ev.noarch

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Initiate RHHI deployment using cockpit
2. Enable LVMcache
3. Observe the generated gdeploy config file

Actual results:
---------------
'ignore_lv_errors' is set to 'yes'

Expected results:
-----------------
'ignore_lv_errors' should be set to 'no'

Additional info:
----------------
actual snip in gdeploy config file:
[lv5]
action=setup-cache
ssd=sdc
vgname=gluster_vg_sdb
poolname=gluster_thinpool_sdb
cache_lv=lvcache
cache_lvsize=220
cachemode=writethrough
ignore_lv_errors=yes

Expected:
[lv5]
action=setup-cache
ssd=sdc
vgname=gluster_vg_sdb
poolname=gluster_thinpool_sdb
cache_lv=lvcache
cache_lvsize=220
cachemode=writethrough
ignore_lv_errors=no

Comment 1 Sandro Bonazzola 2018-03-14 12:29:02 UTC
patches are included in 4.2.2 build happening today

Comment 2 Mugdha Soni 2018-04-17 11:03:04 UTC
Created attachment 1422995 [details]
screenshot of ignore lv error

Comment 3 Mugdha Soni 2018-04-17 11:10:53 UTC
Tested with the following-:

1. RedHat-release-virtualization-host-4.2-2.1.el7.x86_64
2. Cockpit-ovirt-dashboard-0.11.20-1
3. gdeploy-2.0.2-19.el7rhgs.noarch

Following were the steps performed to test:-

1.Log in to the cockpit UI and configure all the parameters required for the gluster deployment.

2. Check the gdeploy config file and there is the presence of parameter of 'ignore_lv_errors=no'.

3.The gdeploy execution halts whenever there is an lvmcache error.


Created an attachment 1422995 [details].

Comment 4 Sandro Bonazzola 2018-04-18 12:24:49 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.