Bug 1550989

Summary: gdeploy should stop execution when enableing lvmcache fails
Product: [oVirt] cockpit-ovirt Reporter: SATHEESARAN <sasundar>
Component: GdeployAssignee: Parth Dhanjal <dparth>
Status: CLOSED CURRENTRELEASE QA Contact: Mugdha Soni <musoni>
Severity: medium Docs Contact:
Priority: medium    
Version: 0.11.12CC: bugs, lveyde, rhs-bugs, sabose
Target Milestone: ovirt-4.2.2Flags: sasundar: ovirt-4.2?
sasundar: planning_ack?
rule-engine: devel_ack+
sasundar: testing_ack+
Target Release: 0.11.17   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.17-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1550988 Environment:
Last Closed: 2018-04-18 12:24:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1550988    
Attachments:
Description Flags
screenshot of ignore lv error none

Description SATHEESARAN 2018-03-02 13:51:40 UTC 
+++ This bug was initially created as a clone of Bug #1550988 +++

Description of problem:
------------------------
gdeploy execution should halt when the task of enabling lvmcache fails.

In gdeploy terms - 'ignore_lv_errors' should be set to 'no' under lvmcache enabling section in generated config file

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.11.12-0.1.el7ev.noarch

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Initiate RHHI deployment using cockpit
2. Enable LVMcache
3. Observe the generated gdeploy config file

Actual results:
---------------
'ignore_lv_errors' is set to 'yes'

Expected results:
-----------------
'ignore_lv_errors' should be set to 'no'

Additional info:
----------------
actual snip in gdeploy config file:
[lv5]
action=setup-cache
ssd=sdc
vgname=gluster_vg_sdb
poolname=gluster_thinpool_sdb
cache_lv=lvcache
cache_lvsize=220
cachemode=writethrough
ignore_lv_errors=yes

Expected:
[lv5]
action=setup-cache
ssd=sdc
vgname=gluster_vg_sdb
poolname=gluster_thinpool_sdb
cache_lv=lvcache
cache_lvsize=220
cachemode=writethrough
ignore_lv_errors=no
Comment 1 Sandro Bonazzola 2018-03-14 12:29:02 UTC 
patches are included in 4.2.2 build happening today
Comment 2 Mugdha Soni 2018-04-17 11:03:04 UTC 
Created attachment 1422995 [details]
screenshot of ignore lv error
Comment 3 Mugdha Soni 2018-04-17 11:10:53 UTC 
Tested with the following-:

1. RedHat-release-virtualization-host-4.2-2.1.el7.x86_64
2. Cockpit-ovirt-dashboard-0.11.20-1
3. gdeploy-2.0.2-19.el7rhgs.noarch

Following were the steps performed to test:-

1.Log in to the cockpit UI and configure all the parameters required for the gluster deployment.

2. Check the gdeploy config file and there is the presence of parameter of 'ignore_lv_errors=no'.

3.The gdeploy execution halts whenever there is an lvmcache error.


Created an attachment 1422995 [details].
Comment 4 Sandro Bonazzola 2018-04-18 12:24:49 UTC 
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.