Bug 1551179

Summary: Automatic configuration of fencing fails on: stonith option 'action' is deprecated and should not be used
Product: Red Hat OpenStack Reporter: Marian Krcmarik <mkrcmari>
Component: python-tripleoclientAssignee: Michele Baldessari <michele>
Status: CLOSED ERRATA QA Contact: nlevinki <nlevinki>
Severity: high Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: chjones, hbrock, jjoyce, jschluet, jslagle, mburns, pkomarov, rhel-osp-director-maint, slinaber, tojeline, tvignaud
Target Milestone: betaKeywords: Triaged
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-tripleoclient-9.2.0-2.el7ost openstack-tripleo-common-8.5.1-0.20180326153322.91f52e9.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-27 13:46:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Marian Krcmarik 2018-03-03 00:55:45 UTC
Description of problem:
Automatic fencing configuration fails on:


overcloud.AllNodesDeploySteps.ControllerDeployment_Step5.2:
  resource_type: OS::Heat::StructuredDeployment
  physical_resource_id: dde00cd2-8e51-4a4d-9c79-8c9f1e5a95a9
  status: CREATE_FAILED
  status_reason: |
    Error: resources[2]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 2
  deploy_stdout: |
    ...
            "                    with Stdlib::Compat::Hash. There is further documentation for validate_legacy function in the README. at [\"/etc/puppet/modules/ssh/manifests/server.pp\", 12]:[\"/var/lib/tripleo-config/puppet_step_config.pp\", 41]", 
            "Error: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20180303-300443-1fhpyxd create failed: Error: stonith option 'action' is deprecated and should not be used, use pcmk_off_action, pcmk_reboot_action instead, use --force to override", 
            "Error: /Stage[main]/Tripleo::Fencing/Pacemaker::Stonith::Fence_ipmilan[52:54:00:c3:de:fd]/Pcmk_stonith[stonith-fence_ipmilan-525400c3defd]/ensure: change from absent to present failed: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20180303-300443-1fhpyxd create failed: Error: stonith option 'action' is deprecated and should not be used, use pcmk_off_action, pcmk_reboot_action instead, use --force to override"
        ]
    }

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Run tripleo overcloud deploy with fencing template.

Actual results:
Fails due to Error: stonith option 'action' is deprecated and sho
uld not be used, use pcmk_off_action, pcmk_reboot_action instead, use --force to override"

Expected results:
Stonith devices configured

Additional info:

Comment 1 Marian Krcmarik 2018-03-05 10:29:57 UTC
Used fencing.yaml

parameter_defaults:
  EnableFencing: true
  FencingConfig:
    devices:
    - agent: fence_ipmilan
      host_mac: 52:54:00:e7:78:f9
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6231'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: ceph-2
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:8c:a0:52
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6230'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: ceph-0
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:4c:f9:59
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6234'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: ceph-1
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:e3:e1:16
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6233'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: compute-1
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:7b:d9:78
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6232'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: compute-0
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:52:d1:d0
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6237'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: controller-1
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:6d:68:1a
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6236'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: controller-0
        privlvl: administrator
    - agent: fence_ipmilan
      host_mac: 52:54:00:c3:de:fd
      params:
        action: reboot
        ipaddr: 172.16.0.1
        ipport: '6235'
        lanplus: true
        login: admin
        passwd: password
        pcmk_host_list: controller-2
        privlvl: administrator

Comment 2 Michele Baldessari 2018-03-06 08:13:27 UTC
Note that the command for overcloud fencing generation does state that you should not use this parameter:
"""
Operation to perform. Valid operations: '
on, off, reboot, status, list, diag, '
monitor or metadata. You should generally '
not use this option.'
"""

I'll see how we can fix this more cleanly though, but for now just omit it from your scripts.

Comment 6 errata-xmlrpc 2018-06-27 13:46:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2086