Bug 1553214

Summary: JavaScript-UI: Wrong behavior of `display on button` checkbox while editing custom group form
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Brian McLaughlin <bmclaugh>
Status: CLOSED ERRATA QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: bmclaugh, cpelland, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.9.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:custom_button:button:generic_object
Fixed In Version: 5.9.2.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1535010 Environment:
Last Closed: 2018-05-07 20:44:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1535010    
Bug Blocks:    
Attachments:
Description Flags
fixed_proof.gif none

Comment 2 CFME Bot 2018-03-08 16:13:25 UTC 
New commits detected on ManageIQ/manageiq-ui-classic/gaprindashvili:

https://github.com/ManageIQ/manageiq-ui-classic/commit/471232b2d2100831bcf3039b8518ccfb3c5bc822
commit 471232b2d2100831bcf3039b8518ccfb3c5bc822
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Thu Feb 15 06:58:00 2018 -0500
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Thu Feb 15 06:58:00 2018 -0500

    Merge pull request #3383 from bmclaughlin/fix-display-on-button-behavior

    Fix logic to correctly check 'display on button' checkbox
    (cherry picked from commit 65241dd33dfa21d66d15d41ff2c680ac4686afdc)

    https://bugzilla.redhat.com/show_bug.cgi?id=1553214

 app/views/shared/buttons/_ab_list.html.haml | 2 +-
 app/views/shared/buttons/_group_form.html.haml | 3 +-
 2 files changed, 3 insertions(+), 2 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/1d340c0bb3091222dfb878be51dd81004686f1cb
commit 1d340c0bb3091222dfb878be51dd81004686f1cb
Author:     Martin Hradil <himdel>
AuthorDate: Tue Feb 20 11:04:36 2018 -0500
Commit:     Martin Hradil <himdel>
CommitDate: Tue Feb 20 11:04:36 2018 -0500

    Merge pull request #3431 from mzazrivec/fix_display_on_button_checkbox

    Button Group: Fix 'Display on Button' checkbox visibility
    (cherry picked from commit d3819e4d9fae5f823a59972452ae26b5267aae17)

    https://bugzilla.redhat.com/show_bug.cgi?id=1553214

 app/views/shared/buttons/_ab_list.html.haml | 2 +-
 app/views/shared/buttons/_group_form.html.haml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 Yadnyawalk Tale 2018-03-22 09:51:05 UTC 
Created attachment 1411650 [details]
fixed_proof.gif

'Display on Button' checkbox is now responsive against 'Save' button. I can save and edit group and button forms now. 

I found 1 buggy issue here, but verifying this Bugzilla since it does not related to checkbox behavior.

Verified on: 5.9.2.0.20180320210136_355c506

Thank you!
Comment 9 errata-xmlrpc 2018-05-07 20:44:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:1328