Bug 1554323

Summary:	Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-PerlX-Maybe-1.001-1.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-12 15:10:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1554322
Bug Blocks:	1554155

Description Petr Pisar 2018-03-12 12:35:31 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-PerlX-Maybe/perl-PerlX-Maybe.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-PerlX-Maybe/perl-PerlX-Maybe-1.001-1.fc29.src.rpm
Description:
This Perl module provides a syntax sugar for passing a pair of variables only
if both of them match some criteria (to be defined usually).

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-03-12 14:10:22 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-PerlX-Maybe-1.001-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(PerlX::Maybe)
      1 perl(strict)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-PerlX-Maybe-1.001-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(PerlX::Maybe) = 1.001
      1 perl-PerlX-Maybe = 1.001-1.fc29
      1 perl(Syntax::Feature::Maybe) = 1.001
Binary provides are Ok.

$ rpmlint ./perl-PerlX-Maybe*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2018-03-12 14:16:41 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-PerlX-Maybe

Comment 3 Petr Pisar 2018-03-12 15:10:18 UTC

Thank you for the review and the repository.