Bug 1554322 - Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX::Maybe
Summary: Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX::Maybe
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1554323
TreeView+ depends on / blocked
 
Reported: 2018-03-12 12:24 UTC by Petr Pisar
Modified: 2018-03-12 14:08 UTC (History)
2 users (show)

Fixed In Version: perl-PerlX-Maybe-XS-1.001-1.fc29
Clone Of:
Environment:
Last Closed: 2018-03-12 14:08:47 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2018-03-12 12:24:04 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-PerlX-Maybe-XS/perl-PerlX-Maybe-XS.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-PerlX-Maybe-XS/perl-PerlX-Maybe-XS-1.001-1.fc29.src.rpm
Description:
This is a faster implementation of PerlX::Maybe Perl module.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-03-12 13:13:27 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-PerlX-Maybe-XS-1.001-1.fc29.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.26()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-PerlX-Maybe-XS-1.001-1.fc29.x86_64.rpm | sort | uniq -c
      1 perl(PerlX::Maybe::XS) = 1.001
      1 perl-PerlX-Maybe-XS = 1.001-1.fc29
      1 perl-PerlX-Maybe-XS(x86-64) = 1.001-1.fc29
Binary provides are Ok.

$ rpmlint ./perl-PerlX-Maybe-XS*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2018-03-12 13:39:45 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-PerlX-Maybe-XS

Comment 3 Petr Pisar 2018-03-12 14:08:47 UTC
Thank you for the review and the repository.

I also added a missing dependency on perl-devel.


Note You need to log in before you can comment on or make changes to this bug.