Bug 1554339

Summary:	[RFE] Automatically make windows-guest-tools ISO available in data domain
Product:	[oVirt] ovirt-engine	Reporter:	Yedidyah Bar David <didi>
Component:	Setup.Engine	Assignee:	Gal Zaidman <gzaidman>
Status:	CLOSED WONTFIX	QA Contact:	Lucie Leistnerova <lleistne>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.2.0	CC:	bugs, lleistne
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-20 12:53:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1592825
Bug Blocks:	1588498

Description Yedidyah Bar David 2018-03-12 13:41:11 UTC

Description of problem:

Until 4.1, the windows-guest-tools ISO image was automatically uploaded to the NFS ISO domain, by engine-setup, if such a domain was created by it.

Creation of an NFS ISO domain by engine-setup on the engine machine is risky and deprecated, see bug 1332813. In 4.2, engine-setup does not query about this anymore, and also in 4.1 it defaulted to not create one.

4.2 engine has new relevant functionality, including use of a normal data domain also for ISO images (to be attached to VMs as a CD/DVD drive), and a new GUI-based ISO image uploader that replaces the ovirt-iso-uploader.

It will be nice if the old behavior is re-implemented using the new functionality. A brief sketch of how it can look:

- Installation of the windows-guest-tools ISO RPM somehow triggers the engine to notice and handle

- Some widget in the admin ui lets the admin upload the image to a data domain

- Alternatively, if the engine was configured to do so beforehand, it automatically uploads the image. This is especially useful when updates are available

Additional notes:

This might be considered as a bug, not an RFE, even a regression.

The existing functionality probably still works on systems upgraded from 4.1, where engine-setup was asked to create the ISO domain.

It might even work on 4.2, if running engine-setup with:

--otopi-environment=OVESETUP_SYSTEM/nfsConfigEnabled=bool:True

As mentioned above, this is risky and deprecated/unsupported.

Comment 1 Yaniv Lavi 2018-06-12 10:00:13 UTC

I think a better flow would be:
- Press a button to upload tools to a domain.
- Ansible script is run and install RPM, handles the upload (progress is via the uploading progress).

Comment 2 Sandro Bonazzola 2019-11-20 12:53:38 UTC

We are not going to ship guest tools anymore in 4.4. Closing wontfix.