Bug 1554482

Summary: subscription-manager register --type=RHUI fails to pass the consumer type to Candlepin
Product: Red Hat Enterprise Linux 7 Reporter: John Sefler <jsefler>
Component: subscription-managerAssignee: candlepin-bugs
Status: CLOSED ERRATA QA Contact: Red Hat subscription-manager QE Team <rhsm-qe>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 7.5CC: candlepin-bugs, cdonnell, csnyder, ktordeur, rbiba, salmy, skallesh, toneata
Target Milestone: rcKeywords: Regression, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1554486 1555215 (view as bug list) Environment:
Last Closed: 2018-10-30 10:36:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1554486, 1555215    

Description John Sefler 2018-03-12 18:24:18 UTC
Description of problem:
During the implementation of RFE Bug 1461003 which was used to remove the ability to register with a non-system consumer type, we lost the ability to register with --type=RHUI.  Subsequent Bug 1485008 attempted to restore the ability to register with --type=RHUI but failed to restore enough to pass the data to the candlepin server.


Version-Release number of selected component (if applicable):
[root@jsefler-rhel7server ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 2.2.2-1
subscription management rules: 5.26
subscription-manager: 1.20.10-1.el7


How reproducible:


Steps to Reproduce:
[root@jsefler-rhel7server ~]# subscription-manager register --serverurl=subscription.rhsm.stage.redhat.com:443/subscription --username=stage_sku_test_475 --type=RHUI
Registering to: subscription.rhsm.stage.redhat.com:443/subscription
Password: 
The system has been registered with ID: 13b64e5d-ec73-4f2c-9b5e-95312a93935a
The registered system name is: jsefler-rhel7server.usersys.redhat.com
[root@jsefler-rhel7server ~]# 
[root@jsefler-rhel7server ~]# curl -k --stderr /dev/null --cert /etc/pki/consumer/cert.pem --key /etc/pki/consumer/key.pem 'https://subscription.rhsm.stage.redhat.com:443/subscription/consumers/13b64e5d-ec73-4f2c-9b5e-95312a93935a?include=type' | python -m json.tool
{
    "type": {
        "id": "0",
        "label": "system",     <========== EXPECTED "RHUI"
        "manifest": false
    }
}


Actual results:
  above

Expected results:
  "label": "RHUI",
  

Additional info:

This appears to be the offending commit that omitted the type=self.options.consumer during the creation of the consumer from the service.register/admin_cp.registerConsumer:   https://github.com/candlepin/subscription-manager/commit/81594f3700894cfc95583787499ac7c7a9d69146

Influential pull requests:
https://github.com/candlepin/subscription-manager/pull/1673
https://github.com/candlepin/subscription-manager/pull/1684
https://github.com/candlepin/subscription-manager/pull/1692

Comment 11 Shwetha Kallesh 2018-06-11 09:23:56 UTC
Verification:

[root@localhost ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 2.2.3-1
subscription management rules: 5.26
subscription-manager: 1.21.5-2.el7

[root@localhost ~]# subscription-manager register --serverurl=subscription.rhsm.stage.redhat.com:443/subscription --username=stage_sku_test_475 --type=RHUI --force
Unregistering from: subscription.rhsm.stage.redhat.com:443/subscription
The system with UUID 181ccdf7-e6f0-4d8a-8374-4bc395f805c6 has been unregistered
All local data removed
Registering to: subscription.rhsm.stage.redhat.com:443/subscription
Password: 
The system has been registered with ID: 52183db9-41ee-4466-b4f5-915ad550f270
The registered system name is: localhost.localdomain

[root@localhost ~]#  curl -k --stderr /dev/null --cert /etc/pki/consumer/cert.pem --key /etc/pki/consumer/key.pem 'https://subscription.rhsm.stage.redhat.com:443/subscription/consumers/52183db9-41ee-4466-b4f5-915ad550f270?include=type' | python -m json.tool
{
    "type": {
        "id": "4",
        "label": "RHUI",
        "manifest": false
    }
}

Comment 13 errata-xmlrpc 2018-10-30 10:36:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3153