Bug 1554751

Summary:	[downstream clone - 4.1.10] NGN upgrade should fail if it finds a badly placed local storage domain
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	ovirt-node-ng	Assignee:	Ryan Barry <rbarry>
Status:	CLOSED ERRATA	QA Contact:	Huijuan Zhao <huzhao>
Severity:	high	Docs Contact:
Priority:	medium
Version:	4.2.1	CC:	cshao, danken, dfediuck, eheftman, huzhao, jiaczhan, qiyuan, rbarry, weiwang, yaniwang, ycui, yzhao
Target Milestone:	ovirt-4.1.10	Keywords:	Rebase, ZStream
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously, Red Hat Virtualization Hypervisor did not warn users if a local storage domain was placed on the same file system as / (root). As a result, local storage domains on the same file system as / were not migrated when the Hypervisor was updated, leading to a potential loss of local virtual machines. In this release, the Hypervisor now fails to upgrade if storage domains are located on the same file system as /, and a message appears instructing the user how to resolved the issue and local storage domains on / are no longer at risk.	Story Points:	---
Clone Of:	1549630	Environment:
Last Closed:	2018-03-20 16:41:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1549630
Bug Blocks:

Description RHV bug bot 2018-03-13 10:09:39 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1549630 +++
======================================================================

Description of problem:
When you try to upgrade NGN with local storage in not persistent path your VMS will disappear, customer should be warned before upgrade if needed.

Version-Release number of selected component (if applicable):
RHV 4.2 Beta2
Red Hat Virtualization Host 4.2.1 (el7.4)

How reproducible:
100%

Steps to Reproduce:
1. Have local storage on NGN host, not in persistent path
2. Update NGN host
3. VMs are gone

Actual results:
VMs are gone

Expected results:
Engine should not allow to add local storage to non-persistent path of NGN

(Originally by Pavol Brilla)

Comment 3 RHV bug bot 2018-03-13 10:09:50 UTC

Virt QE reproduced this issue, but not exactly same as Comment 0.

Test version:
From: rhvh-4.2.1.1-0.20180115.0
To:   rhvh-4.2.1.2-0.20180205.0

Test steps:
1. Install rhvh-4.2.1.1-0.20180115.0, add host to rhvm-4.1 with local storage type
2. Create non-persistent path on host, 
   # mkdir /test/test
   # chmod 777 /test/test
3. Add above local storage(/test/test) to host in rhvm, and create vm1
4. Setup local repos on host, then upgrade host from rhvm side
5. After upgrade, check /test/test on host, and check the storage and vm1 status in rhvm

Actual results:
1. After step 5, there is no /test/test on host, but the storage in rhvm is still up with space N/A, vm1 is still there but can not be up.

(Originally by Huijuan Zhao)

Comment 4 cshao 2018-03-14 06:42:12 UTC

Ryan,
Could you please help to move this bug to ON_QA status? Then QE will verify it.

Comment 5 Huijuan Zhao 2018-03-14 13:28:01 UTC

Test version:
From: rhvh-4.1-0.20171207.0
To:   rhvh-4.1-0.20180314.0

Test steps:
Same as comment 3

Test results:
After step 4, upgrade failed both from rhvm side and from rhvh side.

So this bug is fixed in rhvh-4.1-0.20180314.0, will change the status to verified.

Comment 9 errata-xmlrpc 2018-03-20 16:41:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0570

Comment 10 Franta Kust 2019-05-16 13:05:02 UTC

BZ<2>Jira Resync