Bug 1549630 – NGN upgrade should fail if it finds a badly placed local storage domain

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1549630 - NGN upgrade should fail if it finds a badly placed local storage domain

Summary:	NGN upgrade should fail if it finds a badly placed local storage domain

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-node-ng (Show other bugs)
Sub Component:
Version:	4.2.1
Hardware:	All Linux

Priority	medium Severity high
Target Milestone:	ovirt-4.2.2
Target Release:	---
Assigned To:	Ryan Barry
QA Contact:	Huijuan Zhao
Docs Contact:

URL:
Whiteboard:
Keywords:	Rebase, ZStream

Depends On:
Blocks:	1554751
	Show dependency tree / graph

Reported:	2018-02-27 09:16 EST by Pavol Brilla
Modified:	2018-05-15 13:58 EDT (History)
CC List:	12 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	Previously, Red Hat Virtualization Host did not warn users if a local storage domain was placed on the same file system as / (root). As a result, local storage domains on the same file system as / were not migrated when the host was updated, leading to a potential loss of local virtual machines. In this release, the host now fails to upgrade if storage domains are located on the same file system as /, and a message appears instructing the user how to resolved the issue and local storage domains on / are no longer at risk.
Story Points:	---
Clone Of:
Clones:	1554751 (view as bug list)
Environment:
Last Closed:	2018-05-15 13:57:44 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Node
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	huzhao: testing_plan_complete+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	88313	master	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:54 EST
oVirt gerrit	88652	ovirt-4.2-pre	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:56 EST
oVirt gerrit	88653	ovirt-4.2-snapshot	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:56 EST
oVirt gerrit	88654	ovirt-4.2	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:56 EST
oVirt gerrit	88655	ovirt-4.1	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:56 EST
oVirt gerrit	88656	ovirt-4.1-pre	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:56 EST
oVirt gerrit	88657	ovirt-4.1-snapshot	MERGED	image-update: fail upgrades if there is a local storage domain on /	2018-03-08 07:56 EST
Red Hat Product Errata	RHSA-2018:1524	None	None	None	2018-05-15 13:58 EDT

Groups: None (edit)

Description Pavol Brilla 2018-02-27 09:16:19 EST

Description of problem:
When you try to upgrade NGN with local storage in not persistent path your VMS will disappear, customer should be warned before upgrade if needed.

Version-Release number of selected component (if applicable):
RHV 4.2 Beta2
Red Hat Virtualization Host 4.2.1 (el7.4)

How reproducible:
100%

Steps to Reproduce:
1. Have local storage on NGN host, not in persistent path
2. Update NGN host
3. VMs are gone

Actual results:
VMs are gone

Expected results:
Engine should not allow to add local storage to non-persistent path of NGN

Comment 2 Huijuan Zhao 2018-03-01 10:13:06 EST

Virt QE reproduced this issue, but not exactly same as Comment 0.

Test version:
From: rhvh-4.2.1.1-0.20180115.0
To:   rhvh-4.2.1.2-0.20180205.0

Test steps:
1. Install rhvh-4.2.1.1-0.20180115.0, add host to rhvm-4.1 with local storage type
2. Create non-persistent path on host, 
   # mkdir /test/test
   # chmod 777 /test/test
3. Add above local storage(/test/test) to host in rhvm, and create vm1
4. Setup local repos on host, then upgrade host from rhvm side
5. After upgrade, check /test/test on host, and check the storage and vm1 status in rhvm

Actual results:
1. After step 5, there is no /test/test on host, but the storage in rhvm is still up with space N/A, vm1 is still there but can not be up.

Comment 4 Huijuan Zhao 2018-03-23 01:47:05 EDT

Test version:
From: rhvh-4.1-0.20171207.0
To:   rhvh-4.2-0.20180322.0

Test steps:
Same as comment 2

Test results:
After step 4, upgrade failed both from rhvm side and from rhvh side.

So this bug is fixed in rhvh-4.2-0.20180322.0, will change the status to verified.

Comment 6 Huijuan Zhao 2018-04-23 23:19:43 EDT

According to comment 4, change the status to VERIFIED.

Comment 9 errata-xmlrpc 2018-05-15 13:57:44 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:1524

Note You need to log in before you can comment on or make changes to this bug.