Bug 1556412
| Summary: | rubygem-sup: FTBFS in F28 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fedora Release Engineering <releng> |
| Component: | rubygem-sup | Assignee: | Shreyank Gupta <shreyankg> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | dcallagh, jaruga, kumarpraveen.nitdgp, shreyankg, vondruch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-03-25 22:44:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1556732 | ||
| Bug Blocks: | 1555378 | ||
|
Description
Fedora Release Engineering
2018-03-14 23:49:51 UTC
100% [78/78] man/sup.1
ERROR: While executing gem ... (RDoc::Error)
error generating Redwood/ThreadViewMode.html: no implicit conversion of nil into String (TypeError)
Not sure how to get a proper stack trace or line number for the rdoc error though, hmm.
Okay, got it by using the prep'ped sources and running: rdoc --op=asdf --format=darkfish lib man/* --debug error generating Redwood/ThreadViewMode.html: no implicit conversion of nil into String (TypeError) /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/token_stream.rb:64:in `escapeHTML' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/token_stream.rb:64:in `block in to_html' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/token_stream.rb:19:in `map' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/token_stream.rb:19:in `to_html' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/markup.rb:114:in `markup_code' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:168:in `block (5 levels) in generate_class' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:125:in `each' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:125:in `block (4 levels) in generate_class' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:118:in `each' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:118:in `block (3 levels) in generate_class' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:116:in `each' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:116:in `block (2 levels) in generate_class' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/context.rb:765:in `block in each_section' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/context.rb:764:in `each' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/context.rb:764:in `each_section' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/template/darkfish/class.rhtml:54:in `block in generate_class' /usr/share/ruby/erb.rb:885:in `eval' /usr/share/ruby/erb.rb:885:in `result' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:753:in `template_result' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:732:in `block in render_template' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:727:in `open' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:727:in `open' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:727:in `render_template' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:356:in `generate_class' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:382:in `block in generate_class_files' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:379:in `each' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:379:in `generate_class_files' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/generator/darkfish.rb:246:in `generate' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/rdoc.rb:533:in `block in generate' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/rdoc.rb:528:in `chdir' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/rdoc.rb:528:in `generate' /usr/share/gems/gems/rdoc-6.0.1/lib/rdoc/rdoc.rb:507:in `document' /usr/bin/rdoc:20:in `<main>' Okay, found it. The token making rdoc choke was:
{:line_no=>771, :char_no=>59, :kind=>:on_ignored_nl, :text=>nil, :state=>#<Ripper::Lexer::State: EXPR_END>}
So this is:
https://github.com/ruby/rdoc/issues/585
which is apparently fixed in master of rdoc though not in any release.
The code in question is in lib/sup/modes/thread_view_mode.rb line 771:
linetext = @text.slice(curpos, @text.length).flatten(1)
.take_while{|d| d[0] == :text_color and d[1].strip != ""} # Only take up to the first "" alone on its line
.map{|d| d[1].strip}.join("").strip
For now, bug 1556732 is fixed in rawhide but not F28. So this is building again for F29+ but still failing in F28. I have asked on bug 1556732 if the fixed can be backported. This is built in F28 now too. You probably want to submit Bodhi update ... I don't think there is any need, is there? The rubygem-sup code itself has not changed at all. The new build will be the same as the rubygem-sup-0.21.0-7.fc27 one which is already in F28. (In reply to Dan Callaghan from comment #8) > I don't think there is any need, is there? If that was conscious decision, then it is fine with me. People just forget sometimes ;) Oh, well thanks for the reminder. :-) Looks like we'll get a fresh build soon for bug 1003402 anyway. |