Bug 1558036

Summary:	cockpit wizard skips many lines from the ansible callback output
Product:	[oVirt] cockpit-ovirt	Reporter:	Simone Tiraboschi <stirabos>
Component:	Hosted Engine	Assignee:	Ryan Barry <rbarry>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yihui Zhao <yzhao>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	0.11.17	CC:	bugs, cshao, huzhao, qiyuan, rbarry, sabose, sbonazzo, yaniwang, ycui, yzhao
Target Milestone:	ovirt-4.2.2	Flags:	rule-engine: ovirt-4.2+ rule-engine: blocker+ yzhao: testing_ack+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.11.18-0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-29 11:05:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1522712, 1556866

Description Simone Tiraboschi 2018-03-19 13:31:32 UTC

Description of problem:
Cockpit wizard skips many lines from the ansible callback output.

Parsing the ansible callback file with jq we see:
[root@c74he20180302h1 ~]# cat /tmp/initial_clean_out.json | jq -r '. | select(."OVEHOSTED_AC/type"=="OVEHOSTED_AC/info") | ."OVEHOSTED_AC/body"'
TASK [Gathering Facts]
ok: [localhost]
TASK [Stop libvirt]
changed: [localhost]
TASK [Drop vdsm config statements]
TASK [Restore initial abrt config files]
TASK [Restart abrtd]
changed: [localhost]
TASK [Drop libvirt sasl2 configuration by vdsm]
changed: [localhost]
TASK [Stop and disable services]
TASK [Start libvirt]
changed: [localhost]
TASK [Check for leftover local engine VM]
changed: [localhost]
TASK [Destroy leftover local engine VM]
changed: [localhost]
TASK [Check for leftover defined local engine VM]
changed: [localhost]
TASK [Undefine leftover local engine VM]
changed: [localhost]
TASK [Remove eventually entries for the local VM from known_hosts file]
changed: [localhost]


While on cockpit we got just:
[ INFO ] TASK [Gathering Facts]
[ INFO ] ok: [localhost]
[ INFO ] TASK [Stop libvirt]
[ INFO ] changed: [localhost]
[ INFO ] TASK [Drop vdsm config statements]
[ INFO ] TASK [Restore initial abrt config files]
[ INFO ] TASK [Restart abrtd]
[ INFO ] TASK [Drop libvirt sasl2 configuration by vdsm]
[ INFO ] TASK [Stop and disable services]
[ INFO ] TASK [Start libvirt]
[ INFO ] TASK [Check for leftover local engine VM]
[ INFO ] TASK [Destroy leftover local engine VM]
[ INFO ] TASK [Check for leftover defined local engine VM]
[ INFO ] TASK [Undefine leftover local engine VM]
[ INFO ] TASK [Remove eventually entries for the local VM from known_hosts file]


According to what got skipped, it can misses task results and values for the next steps.


Version-Release number of selected component (if applicable):
0.11.17

How reproducible:
100%

Steps to Reproduce:
1. deploy hosted-engine from cockpit
2. compare the output of the json callback with what reaches cockpit
3.

Actual results:
some lines are randomly skipped, according to what got skipped we can see many different side effects on UX side.

Expected results:
all the lines are correctly processed.

Additional info:

Comment 1 Yihui Zhao 2018-03-21 07:02:40 UTC

Tested with 11.17, can reproduce this issue. It misses task results and values for the next steps.

# cat initial_clean_out.json | jq -r '. | select(."OVEHOSTED_AC/type"=="OVEHOSTED_AC/info") | ."OVEHOSTED_AC/body"'
TASK [Gathering Facts]
ok: [localhost]
TASK [Stop libvirt]
changed: [localhost]
TASK [Drop vdsm config statements]
TASK [Restore initial abrt config files]
TASK [Restart abrtd]
changed: [localhost]
TASK [Drop libvirt sasl2 configuration by vdsm]
changed: [localhost]
TASK [Stop and disable services]
TASK [Start libvirt]
changed: [localhost]
TASK [Check for leftover local engine VM]
changed: [localhost]
TASK [Destroy leftover local engine VM]
skipping: [localhost]
TASK [Check for leftover defined local engine VM]
changed: [localhost]
TASK [Undefine leftover local engine VM]
skipping: [localhost]
TASK [Remove eventually entries for the local VM from known_hosts file]
ok: [localhost]




From the cockpit :
[ INFO ] TASK [Gathering Facts]
[ INFO ] ok: [localhost]
[ INFO ] TASK [Stop libvirt]
[ INFO ] changed: [localhost]
[ INFO ] TASK [Drop vdsm config statements]
[ INFO ] TASK [Restore initial abrt config files]
[ INFO ] TASK [Restart abrtd]
[ INFO ] TASK [Drop libvirt sasl2 configuration by vdsm]
[ INFO ] TASK [Stop and disable services]
[ INFO ] TASK [Start libvirt]
[ INFO ] TASK [Check for leftover local engine VM]
[ INFO ] TASK [Destroy leftover local engine VM]
[ INFO ] skipping: [localhost]
[ INFO ] TASK [Check for leftover defined local engine VM]
[ INFO ] TASK [Undefine leftover local engine VM]
[ INFO ] TASK [Remove eventually entries for the local VM from known_hosts file]

Comment 2 Simone Tiraboschi 2018-03-21 10:14:56 UTC

*** Bug 1558888 has been marked as a duplicate of this bug. ***

Comment 3 Yihui Zhao 2018-03-22 08:30:54 UTC

Tested with cockpit-ovirt-dashboard-0.11.18-1.el7ev.noarch, compare all the files under /tmp/*.json to the lines from cockpit, they are the same , and not skip any lines from the ansible callback output.

So, change the bug's status to verified.

Comment 4 Sandro Bonazzola 2018-03-29 11:05:25 UTC

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.