Bug 1558036 - cockpit wizard skips many lines from the ansible callback output
Summary: cockpit wizard skips many lines from the ansible callback output
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Hosted Engine
Version: 0.11.17
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.2.2
: ---
Assignee: Ryan Barry
QA Contact: Yihui Zhao
URL:
Whiteboard:
: 1558888 (view as bug list)
Depends On:
Blocks: 1522712 1556866
TreeView+ depends on / blocked
 
Reported: 2018-03-19 13:31 UTC by Simone Tiraboschi
Modified: 2018-03-29 11:05 UTC (History)
10 users (show)

Fixed In Version: cockpit-ovirt-0.11.18-0.1
Clone Of:
Environment:
Last Closed: 2018-03-29 11:05:25 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+
yzhao: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 89158 0 ovirt-4.2 MERGED he: invalidate past results on each execution 2018-03-19 15:36:22 UTC
oVirt gerrit 89178 0 master MERGED wizard: Ensure all output lines are processed 2018-03-20 13:56:25 UTC
oVirt gerrit 89194 0 ovirt-4.2 MERGED he: invalidate past results on each execution 2018-03-19 15:54:30 UTC
oVirt gerrit 89204 0 master MERGED ansible: cockpit: fail early on wrong LOCAL_VM_DIR 2018-09-03 09:34:32 UTC
oVirt gerrit 89208 0 ovirt-hosted-engine-setup-2.2 MERGED ansible: cockpit: fail early on wrong LOCAL_VM_DIR 2018-03-19 17:53:34 UTC
oVirt gerrit 89244 0 ovirt-4.2 MERGED wizard: Ensure all output lines are processed 2018-03-20 14:00:10 UTC

Description Simone Tiraboschi 2018-03-19 13:31:32 UTC
Description of problem:
Cockpit wizard skips many lines from the ansible callback output.

Parsing the ansible callback file with jq we see:
[root@c74he20180302h1 ~]# cat /tmp/initial_clean_out.json | jq -r '. | select(."OVEHOSTED_AC/type"=="OVEHOSTED_AC/info") | ."OVEHOSTED_AC/body"'
TASK [Gathering Facts]
ok: [localhost]
TASK [Stop libvirt]
changed: [localhost]
TASK [Drop vdsm config statements]
TASK [Restore initial abrt config files]
TASK [Restart abrtd]
changed: [localhost]
TASK [Drop libvirt sasl2 configuration by vdsm]
changed: [localhost]
TASK [Stop and disable services]
TASK [Start libvirt]
changed: [localhost]
TASK [Check for leftover local engine VM]
changed: [localhost]
TASK [Destroy leftover local engine VM]
changed: [localhost]
TASK [Check for leftover defined local engine VM]
changed: [localhost]
TASK [Undefine leftover local engine VM]
changed: [localhost]
TASK [Remove eventually entries for the local VM from known_hosts file]
changed: [localhost]


While on cockpit we got just:
[ INFO ] TASK [Gathering Facts]
[ INFO ] ok: [localhost]
[ INFO ] TASK [Stop libvirt]
[ INFO ] changed: [localhost]
[ INFO ] TASK [Drop vdsm config statements]
[ INFO ] TASK [Restore initial abrt config files]
[ INFO ] TASK [Restart abrtd]
[ INFO ] TASK [Drop libvirt sasl2 configuration by vdsm]
[ INFO ] TASK [Stop and disable services]
[ INFO ] TASK [Start libvirt]
[ INFO ] TASK [Check for leftover local engine VM]
[ INFO ] TASK [Destroy leftover local engine VM]
[ INFO ] TASK [Check for leftover defined local engine VM]
[ INFO ] TASK [Undefine leftover local engine VM]
[ INFO ] TASK [Remove eventually entries for the local VM from known_hosts file]


According to what got skipped, it can misses task results and values for the next steps.


Version-Release number of selected component (if applicable):
0.11.17

How reproducible:
100%

Steps to Reproduce:
1. deploy hosted-engine from cockpit
2. compare the output of the json callback with what reaches cockpit
3.

Actual results:
some lines are randomly skipped, according to what got skipped we can see many different side effects on UX side.

Expected results:
all the lines are correctly processed.

Additional info:

Comment 1 Yihui Zhao 2018-03-21 07:02:40 UTC
Tested with 11.17, can reproduce this issue. It misses task results and values for the next steps.

# cat initial_clean_out.json | jq -r '. | select(."OVEHOSTED_AC/type"=="OVEHOSTED_AC/info") | ."OVEHOSTED_AC/body"'
TASK [Gathering Facts]
ok: [localhost]
TASK [Stop libvirt]
changed: [localhost]
TASK [Drop vdsm config statements]
TASK [Restore initial abrt config files]
TASK [Restart abrtd]
changed: [localhost]
TASK [Drop libvirt sasl2 configuration by vdsm]
changed: [localhost]
TASK [Stop and disable services]
TASK [Start libvirt]
changed: [localhost]
TASK [Check for leftover local engine VM]
changed: [localhost]
TASK [Destroy leftover local engine VM]
skipping: [localhost]
TASK [Check for leftover defined local engine VM]
changed: [localhost]
TASK [Undefine leftover local engine VM]
skipping: [localhost]
TASK [Remove eventually entries for the local VM from known_hosts file]
ok: [localhost]




From the cockpit :
[ INFO ] TASK [Gathering Facts]
[ INFO ] ok: [localhost]
[ INFO ] TASK [Stop libvirt]
[ INFO ] changed: [localhost]
[ INFO ] TASK [Drop vdsm config statements]
[ INFO ] TASK [Restore initial abrt config files]
[ INFO ] TASK [Restart abrtd]
[ INFO ] TASK [Drop libvirt sasl2 configuration by vdsm]
[ INFO ] TASK [Stop and disable services]
[ INFO ] TASK [Start libvirt]
[ INFO ] TASK [Check for leftover local engine VM]
[ INFO ] TASK [Destroy leftover local engine VM]
[ INFO ] skipping: [localhost]
[ INFO ] TASK [Check for leftover defined local engine VM]
[ INFO ] TASK [Undefine leftover local engine VM]
[ INFO ] TASK [Remove eventually entries for the local VM from known_hosts file]

Comment 2 Simone Tiraboschi 2018-03-21 10:14:56 UTC
*** Bug 1558888 has been marked as a duplicate of this bug. ***

Comment 3 Yihui Zhao 2018-03-22 08:30:54 UTC
Tested with cockpit-ovirt-dashboard-0.11.18-1.el7ev.noarch, compare all the files under /tmp/*.json to the lines from cockpit, they are the same , and not skip any lines from the ansible callback output.

So, change the bug's status to verified.

Comment 4 Sandro Bonazzola 2018-03-29 11:05:25 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.