Bug 1558490

This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Moving to Rawhide, though it's outdated everywhere.

Created attachment 1439053 [details]
Spec file for nlohmann::json 3.1.2

I tried my hand at fixing this, but I can't push changes back up to my git fork for some reason. I've attached the .spec file. The new MD5 checksum is

557651b017c36ad596ba3b577ba1b539  v3.1.2.tar.gz

I had to remove the "make cppcheck" step because it appears to be failing due to a false alarm. I opened an issue on the project here: https://github.com/nlohmann/json/issues/1101

However, the units tests are all passing and the rpm builds through mock on rawhide and rpmlint is clean.

-Phil

(In reply to Philip Salvaggio from comment #3)
> Created attachment 1439053 [details]
> Spec file for nlohmann::json 3.1.2
> 
> I tried my hand at fixing this, but I can't push changes back up to my git
> fork for some reason. I've attached the .spec file. The new MD5 checksum is
> 
> 557651b017c36ad596ba3b577ba1b539  v3.1.2.tar.gz
> 
> I had to remove the "make cppcheck" step because it appears to be failing
> due to a false alarm. I opened an issue on the project here:
> https://github.com/nlohmann/json/issues/1101
> 
> However, the units tests are all passing and the rpm builds through mock on
> rawhide and rpmlint is clean.
> 
> -Phil

I tried to build the newest release in koji but the unit tests fail there:

https://kojipkgs.fedoraproject.org//work/tasks/5793/27105793/build.log

---
71/78 Test #37: test-inspection_default .............   Passed    1.07 sec
72/78 Test #38: test-inspection_all .................   Passed    1.07 sec
65: /usr/include/c++/8/valarray:575: const _Tp& std::valarray<_Tp>::operator[](std::size_t) const [with _Tp = double; std::size_t = long unsigned int]: Assertion '__builtin_expect(__i < this->size(), true)' failed.
...
...
...
The following tests FAILED:
	 65 - test-regression_default (Child aborted)
	 66 - test-regression_all (Child aborted)
---

Created attachment 1440029 [details]
build.log

Hmm, our builds do seem a bit different. Mine just goes into the source directory and runs the "make check" command whereas yours seems to execute CMake and builds Catch2 from source. I'm not sure why that would cause us different results in the unit tests. I attached my build.log from mock.

(In reply to Philip Salvaggio from comment #5)
> Created attachment 1440029 [details]
> build.log
> 
> Hmm, our builds do seem a bit different. Mine just goes into the source
> directory and runs the "make check" command whereas yours seems to execute
> CMake and builds Catch2 from source. I'm not sure why that would cause us
> different results in the unit tests. I attached my build.log from mock.

Thanks for the help here.
I'm trying to use the standard macros to execute the build as much as possible.
I'll investigate further.

This is a dependency of mkvtoolnix and I'd like to see it updated to 3.1.1+ as well.

json-3.1.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-15059b647a

json-3.1.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-15059b647a

json-3.1.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.