Bug 1558490 - json is outdated
Summary: json is outdated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: json
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Kopeček
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-20 10:42 UTC by Elliott Sales de Andrade
Modified: 2018-07-26 15:04 UTC (History)
6 users (show)

Fixed In Version: json-3.1.2-2.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-26 15:04:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Spec file for nlohmann::json 3.1.2 (3.32 KB, text/plain)
2018-05-19 22:58 UTC, Philip Salvaggio
no flags Details
build.log (146.75 KB, text/plain)
2018-05-22 12:58 UTC, Philip Salvaggio
no flags Details

Description Elliott Sales de Andrade 2018-03-20 10:42:49 UTC
The version in Fedora is 2.0.2, but the latest release is 3.1.2 [1]. The headers were moved around a bit, so it might be a bit of a breaking change.

There is also now a cmake build which uses nlohmann_json as the project name. A possible non-breaking change could be to add a new package under this name instead. I was beginning to package it with that name before I realized that this package already existed. However, I need the new version in order to build Xeus, so I can't rely on this one.

[1] https://github.com/nlohmann/json/releases/tag/v3.1.2

Comment 1 Fedora End Of Life 2018-05-03 07:54:45 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 2 Elliott Sales de Andrade 2018-05-03 22:51:43 UTC
Moving to Rawhide, though it's outdated everywhere.

Comment 3 Philip Salvaggio 2018-05-19 22:58:11 UTC
Created attachment 1439053 [details]
Spec file for nlohmann::json 3.1.2

I tried my hand at fixing this, but I can't push changes back up to my git fork for some reason. I've attached the .spec file. The new MD5 checksum is

557651b017c36ad596ba3b577ba1b539  v3.1.2.tar.gz

I had to remove the "make cppcheck" step because it appears to be failing due to a false alarm. I opened an issue on the project here: https://github.com/nlohmann/json/issues/1101

However, the units tests are all passing and the rpm builds through mock on rawhide and rpmlint is clean.

-Phil

Comment 4 Daniel Kopeček 2018-05-21 07:19:43 UTC
(In reply to Philip Salvaggio from comment #3)
> Created attachment 1439053 [details]
> Spec file for nlohmann::json 3.1.2
> 
> I tried my hand at fixing this, but I can't push changes back up to my git
> fork for some reason. I've attached the .spec file. The new MD5 checksum is
> 
> 557651b017c36ad596ba3b577ba1b539  v3.1.2.tar.gz
> 
> I had to remove the "make cppcheck" step because it appears to be failing
> due to a false alarm. I opened an issue on the project here:
> https://github.com/nlohmann/json/issues/1101
> 
> However, the units tests are all passing and the rpm builds through mock on
> rawhide and rpmlint is clean.
> 
> -Phil

I tried to build the newest release in koji but the unit tests fail there:

https://kojipkgs.fedoraproject.org//work/tasks/5793/27105793/build.log

---
71/78 Test #37: test-inspection_default .............   Passed    1.07 sec
72/78 Test #38: test-inspection_all .................   Passed    1.07 sec
65: /usr/include/c++/8/valarray:575: const _Tp& std::valarray<_Tp>::operator[](std::size_t) const [with _Tp = double; std::size_t = long unsigned int]: Assertion '__builtin_expect(__i < this->size(), true)' failed.
...
...
...
The following tests FAILED:
	 65 - test-regression_default (Child aborted)
	 66 - test-regression_all (Child aborted)
---

Comment 5 Philip Salvaggio 2018-05-22 12:58:39 UTC
Created attachment 1440029 [details]
build.log

Hmm, our builds do seem a bit different. Mine just goes into the source directory and runs the "make check" command whereas yours seems to execute CMake and builds Catch2 from source. I'm not sure why that would cause us different results in the unit tests. I attached my build.log from mock.

Comment 6 Daniel Kopeček 2018-05-22 13:02:45 UTC
(In reply to Philip Salvaggio from comment #5)
> Created attachment 1440029 [details]
> build.log
> 
> Hmm, our builds do seem a bit different. Mine just goes into the source
> directory and runs the "make check" command whereas yours seems to execute
> CMake and builds Catch2 from source. I'm not sure why that would cause us
> different results in the unit tests. I attached my build.log from mock.

Thanks for the help here.
I'm trying to use the standard macros to execute the build as much as possible.
I'll investigate further.

Comment 7 Dominik 'Rathann' Mierzejewski 2018-06-24 20:51:51 UTC
This is a dependency of mkvtoolnix and I'd like to see it updated to 3.1.1+ as well.

Comment 8 Fedora Update System 2018-07-25 12:36:57 UTC
json-3.1.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-15059b647a

Comment 9 Fedora Update System 2018-07-26 12:01:57 UTC
json-3.1.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-15059b647a

Comment 10 Fedora Update System 2018-07-26 15:04:29 UTC
json-3.1.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.