Bug 1558906
| Summary: | AttributeError: 'DiskDevice' object has no attribute 'isDisk' | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lukas Ruzicka <lruzicka> | ||||||||||||||||||||||||||||||||
| Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> | ||||||||||||||||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||||||||||||||||
| Version: | 28 | CC: | anaconda-maint-list, awilliam, fzatlouk, jonathan, kellin, lruzicka, rbarlow, robatino, sgallagh, vanmeeuwen+fedora, v.podzimek+fedora, vponcova, vtrefny, wwoods | ||||||||||||||||||||||||||||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||
| Whiteboard: | abrt_hash:13e04e4e6acd635da9a8b9eff154e0b64eab5ae4d69a4a3da4c3c312e10a4d9a; AcceptedBlocker | ||||||||||||||||||||||||||||||||||
| Fixed In Version: | anaconda-28.22.2-6.fc28 | Doc Type: | If docs needed, set a value | ||||||||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||||||||
| Last Closed: | 2018-04-06 19:36:41 UTC | Type: | --- | ||||||||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||||||||||||||||
| Bug Blocks: | 1469204 | ||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||
|
Description
Lukas Ruzicka
2018-03-21 09:38:38 UTC
Created attachment 1411092 [details]
File: anaconda-tb
Created attachment 1411093 [details]
File: anaconda.log
Created attachment 1411094 [details]
File: dbus.log
Created attachment 1411095 [details]
File: dnf.librepo.log
Created attachment 1411096 [details]
File: environ
Created attachment 1411097 [details]
File: hawkey.log
Created attachment 1411098 [details]
File: lorax-packages.log
Created attachment 1411099 [details]
File: lsblk_output
Created attachment 1411100 [details]
File: nmcli_dev_list
Created attachment 1411101 [details]
File: os_info
Created attachment 1411102 [details]
File: program.log
Created attachment 1411103 [details]
File: storage.log
Created attachment 1411104 [details]
File: syslog
Created attachment 1411105 [details]
File: ifcfg.log
Created attachment 1411106 [details]
File: packaging.log
Proposing as a Beta blocker as a violation of "The installer must be able to detect and install to hardware or firmware RAID storage devices." If I understand the bug correctly, it does appear to violate this, as I believe anaconda is likely to crash any time we have a firmware RAID set - firmware RAID sets have 'ancestor' disks that are not shown in the UI, so they will not be selected as install targets when we hit the affected code block:
for disk in (d for d in storage.disks if d.name in onlyuse):
onlyuse.extend(d.name for d in disk.ancestors
if d.name not in onlyuse
and d.isDisk)
so that generator will reach as far as 'd.isDisk' and crash.
I agree, +1 blocker (and that fix looks minimally-invasive). anaconda-28.22.2-6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ce856052a anaconda-28.22.2-6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ce856052a https://www.happyassassin.net/temp/Fedora-28-20180322.n.0-1558906.iso is an ISO containing the updated anaconda and blivet that should fix both this and 1557957. Can you please test with that? Thanks! Discussed during blocker review [1]: AcceptedBlocker (Final) - accepted as a violation of "The installer must be able to detect and install to hardware or firmware RAID storage devices" [1] https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2018-03-22/ Discussed during blocker review [1]: AcceptedBlocker (Beta) - accepted as a violation of "The installer must be able to detect and install to hardware or firmware RAID storage devices" [1] https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2018-03-22/ anaconda-28.22.2-6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. anaconda-28.22.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fd9270cd5 anaconda-28.22.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fd9270cd5 gah, stoppit, Bodhi. (In reply to Adam Williamson from comment #27) > gah, stoppit, Bodhi. This will be fixed in bodhi-3.6.0! https://github.com/fedora-infra/bodhi/pull/2168 |