Description of problem: This happens when you confirm disk selection in automatic mode in partitioning spoke, anaconda crashes. This is not vanilla anaconda, but adjusted with the updates.img from bug 1557957 comment 18. The system has standard disk sda and a raid0 volume created from sdb+sdc using firmware raid. The target of installation was the raid0 volume (sda not selected). Version-Release number of selected component: anaconda-28.22.2 The following was filed automatically by anaconda: anaconda 28.22.2 exception report Traceback (most recent call first): File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/lib/disks.py", line 93, in <genexpr> and d.isDisk) File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/lib/disks.py", line 91, in applyDiskSelection onlyuse.extend(d.name for d in disk.ancestors File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 367, in apply applyDiskSelection(self.storage, self.data, self.selected_disks) File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/gui/hubs/__init__.py", line 439, in spoke_done spoke.apply() File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/gui/spokes/__init__.py", line 79, in on_back_clicked self.main_window.current_action.spoke_done(self) File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 1156, in on_back_clicked NormalSpoke.on_back_clicked(self, button) AttributeError: 'DiskDevice' object has no attribute 'isDisk' Additional info: addons: com_redhat_kdump, com_redhat_docker blivet-gui-utils.log: cmdline: /usr/bin/python3 /sbin/anaconda cmdline_file: BOOT_IMAGE=/images/pxeboot/vmlinuz inst.stage2=hd:LABEL=Fedora-E-dvd-x86_64-28 quiet inst.updates=http://www.happyassassin.net/updates/1557957.0.img executable: /sbin/anaconda hashmarkername: anaconda kernel: 4.16.0-0.rc4.git0.1.fc28.x86_64 product: Fedora release: Cannot get release name. type: anaconda version: 28
Created attachment 1411092 [details] File: anaconda-tb
Created attachment 1411093 [details] File: anaconda.log
Created attachment 1411094 [details] File: dbus.log
Created attachment 1411095 [details] File: dnf.librepo.log
Created attachment 1411096 [details] File: environ
Created attachment 1411097 [details] File: hawkey.log
Created attachment 1411098 [details] File: lorax-packages.log
Created attachment 1411099 [details] File: lsblk_output
Created attachment 1411100 [details] File: nmcli_dev_list
Created attachment 1411101 [details] File: os_info
Created attachment 1411102 [details] File: program.log
Created attachment 1411103 [details] File: storage.log
Created attachment 1411104 [details] File: syslog
Created attachment 1411105 [details] File: ifcfg.log
Created attachment 1411106 [details] File: packaging.log
PR: https://github.com/rhinstaller/anaconda/pull/1405
Proposing as a Beta blocker as a violation of "The installer must be able to detect and install to hardware or firmware RAID storage devices." If I understand the bug correctly, it does appear to violate this, as I believe anaconda is likely to crash any time we have a firmware RAID set - firmware RAID sets have 'ancestor' disks that are not shown in the UI, so they will not be selected as install targets when we hit the affected code block: for disk in (d for d in storage.disks if d.name in onlyuse): onlyuse.extend(d.name for d in disk.ancestors if d.name not in onlyuse and d.isDisk) so that generator will reach as far as 'd.isDisk' and crash.
I agree, +1 blocker (and that fix looks minimally-invasive).
anaconda-28.22.2-6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ce856052a
anaconda-28.22.2-6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ce856052a
https://www.happyassassin.net/temp/Fedora-28-20180322.n.0-1558906.iso is an ISO containing the updated anaconda and blivet that should fix both this and 1557957. Can you please test with that? Thanks!
Discussed during blocker review [1]: AcceptedBlocker (Final) - accepted as a violation of "The installer must be able to detect and install to hardware or firmware RAID storage devices" [1] https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2018-03-22/
Discussed during blocker review [1]: AcceptedBlocker (Beta) - accepted as a violation of "The installer must be able to detect and install to hardware or firmware RAID storage devices" [1] https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2018-03-22/
anaconda-28.22.2-6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
anaconda-28.22.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fd9270cd5
anaconda-28.22.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fd9270cd5
gah, stoppit, Bodhi.
(In reply to Adam Williamson from comment #27) > gah, stoppit, Bodhi. This will be fixed in bodhi-3.6.0! https://github.com/fedora-infra/bodhi/pull/2168