Bug 1558953

Summary: Unexpected import path for chzyer's readline library
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: golang-gopkg-readlineAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-28 09:09:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1556636    
Bug Blocks:    

Description Dominik 'Rathann' Mierzejewski 2018-03-21 11:54:53 UTC
Description of problem:
chzyer's readline library has unexpected import path "gopkg.in/readline.v1". The official example code references it as "github.com/chzyer/readline": https://github.com/chzyer/readline/blob/master/example/readline-demo/readline-demo.go#L12 .

Version-Release number of selected component (if applicable):
golang-gopkg-readline-devel-1.4-2.fc28.noarch

How reproducible:
Always

Steps to Reproduce:
1. Try building Go code (jfrog-cli from https://github.com/JFrogDev/jfrog-cli-go in this case) importing github.com/chzyer/readline

Actual results:
jfrog-client/utils/prompt/prompt.go:5:2: cannot find package "github.com/chzyer/readline" in any of:
	/usr/lib/golang/src/github.com/chzyer/readline (from $GOROOT)
	/builddir/build/BUILD/jfrog-cli-go-1.14.0/_build/src/github.com/chzyer/readline (from $GOPATH)
	/usr/share/gocode/src/github.com/chzyer/readline

Expected results:
Successful compilation.

Comment 1 Robert-André Mauchin 🐧 2018-03-21 15:17:52 UTC
It solved with 1.4-3 where I include both import path but I also need to rename the package. See bug https://bugzilla.redhat.com/show_bug.cgi?id=1556636 As soon is is accepted I will launch the builds.

Comment 2 Dominik 'Rathann' Mierzejewski 2018-06-28 07:30:53 UTC
Is this fixed, then?

Comment 3 Robert-André Mauchin 🐧 2018-06-28 09:09:22 UTC
Yes it should have been fixed a while ago.