Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/faa79ad/golang-gopkg-readline-1.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/micro/fedora-rawhide-x86_64/00728074-golang-gopkg-readline-1/golang-gopkg-readline-1-1.4-3.fc29.src.rpm Description: Pure golang implementation for GNU-Readline kind library Fedora Account System Username: eclipseo This is a rename of golang-gopkg-readline. Please note that this uses the new More Go Packaging guidelines: https://fedoraproject.org/wiki/More_Go_packaging , which standardizes package name via %goname, hence the rename.
The package has some minor issues, see below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - There seems to be some code licensed under the WTFPL license. See licensecheck information below. - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "do What The Fuck you want to Public License", "Unknown or generated". 42 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg- readline-1/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/chzyer(golang-github-chzyer-logex- devel, golang-github-chzyer-test-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- gopkg-readline-1-devel , compat-golang-github-chzyer-readline-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.9 starting (python version = 3.6.4)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.9 INFO: Mock Version: 1.4.9 Finish: chroot init INFO: installing package(s): /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-readline-1/results/golang-gopkg-readline-1-devel-1.4-3.fc28.noarch.rpm /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-readline-1/results/compat-golang-github-chzyer-readline-devel-1.4-3.fc28.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-28-x86_64/root/ --releasever 28 --disableplugin=local --setopt=deltarpm=False install /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-readline-1/results/golang-gopkg-readline-1-devel-1.4-3.fc28.noarch.rpm /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-readline-1/results/compat-golang-github-chzyer-readline-devel-1.4-3.fc28.noarch.rpm Rpmlint ------- Checking: golang-gopkg-readline-1-devel-1.4-3.fc28.noarch.rpm compat-golang-github-chzyer-readline-devel-1.4-3.fc28.noarch.rpm golang-gopkg-readline-1-1.4-3.fc28.src.rpm golang-gopkg-readline-1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/readline.v1/.goipath golang-gopkg-readline-1-devel.noarch: E: zero-length /usr/share/gocode/src/gopkg.in/readline.v1/.goipath compat-golang-github-chzyer-readline-devel.noarch: W: no-documentation compat-golang-github-chzyer-readline-devel.noarch: W: dangling-symlink /usr/share/gocode/src/github.com/chzyer/readline /usr/share/gocode/src/gopkg.in/readline.v1 golang-gopkg-readline-1.src: W: no-%build-section 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Requires -------- compat-golang-github-chzyer-readline-devel (rpmlib, GLIBC filtered): golang(gopkg.in/readline.v1) golang(gopkg.in/readline.v1/example) golang(gopkg.in/readline.v1/example/readline-demo) golang(gopkg.in/readline.v1/example/readline-im) golang(gopkg.in/readline.v1/example/readline-multiline) golang(gopkg.in/readline.v1/example/readline-pass-strength) golang(gopkg.in/readline.v1/example/readline-remote) golang(gopkg.in/readline.v1/example/readline-remote/readline-remote-client) golang(gopkg.in/readline.v1/example/readline-remote/readline-remote-server) golang(gopkg.in/readline.v1/runes) golang-gopkg-readline-1-devel (rpmlib, GLIBC filtered): golang(github.com/chzyer/readline) golang(github.com/nbutton23/zxcvbn-go) Provides -------- compat-golang-github-chzyer-readline-devel: compat-golang-github-chzyer-readline-devel golang(github.com/chzyer/readline) golang(github.com/chzyer/readline/example) golang(github.com/chzyer/readline/example/readline-demo) golang(github.com/chzyer/readline/example/readline-im) golang(github.com/chzyer/readline/example/readline-multiline) golang(github.com/chzyer/readline/example/readline-pass-strength) golang(github.com/chzyer/readline/example/readline-remote) golang(github.com/chzyer/readline/example/readline-remote/readline-remote-client) golang(github.com/chzyer/readline/example/readline-remote/readline-remote-server) golang(github.com/chzyer/readline/runes) golang-gopkg-readline-1-devel: golang(gopkg.in/readline.v1) golang(gopkg.in/readline.v1/runes) golang-gopkg-readline-1-devel golang-gopkg-readline-devel Source checksums ---------------- https://github.com/chzyer/readline/archive/v1.4.tar.gz#/readline-1.4.tar.gz : CHECKSUM(SHA256) this package : 35a66d31d8c91b6b908c40137adf75eac09bb7bd2dbb9dbb12ff74216ec6ba45 CHECKSUM(SHA256) upstream package : 35a66d31d8c91b6b908c40137adf75eac09bb7bd2dbb9dbb12ff74216ec6ba45 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1556636 Buildroot used: fedora-28-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for the review. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/56089be/golang-gopkg-readline-1.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/micro/fedora-rawhide-x86_64/00728791-golang-gopkg-readline-1/golang-gopkg-readline-1-1.4-3.fc29.src.rpm Spec diff: https://github.com/eclipseo/packaging/commit/56089be7595cc45ac6b96d238e3a1f512881d65f#diff-7dea4165b391e4c0ec22559250396d75
Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "do What The Fuck you want to Public License", "Unknown or generated". 42 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg- readline-1/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/gopkg.in/readline.v1/runes(golang-gopkg- readline-devel), /usr/share/gocode/src/gopkg.in/readline.v1(golang- gopkg-readline-devel), /usr/share/gocode/src/github.com/chzyer(golang- github-chzyer-logex-devel, golang-github-chzyer-test-devel), /usr/share/gocode/src/gopkg.in(golang-gopkg-sourcemap-1-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- gopkg-readline-1-devel , compat-golang-github-chzyer-readline-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-gopkg-readline-1-devel-1.4-3.fc29.noarch.rpm compat-golang-github-chzyer-readline-devel-1.4-3.fc29.noarch.rpm golang-gopkg-readline-1-1.4-3.fc29.src.rpm golang-gopkg-readline-1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/readline.v1/.goipath golang-gopkg-readline-1-devel.noarch: E: zero-length /usr/share/gocode/src/gopkg.in/readline.v1/.goipath compat-golang-github-chzyer-readline-devel.noarch: W: no-documentation compat-golang-github-chzyer-readline-devel.noarch: W: dangling-symlink /usr/share/gocode/src/github.com/chzyer/readline /usr/share/gocode/src/gopkg.in/readline.v1 golang-gopkg-readline-1.src: W: no-%build-section 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory compat-golang-github-chzyer-readline-devel.noarch: W: invalid-url URL: https://github.com/chzyer/readline <urlopen error [Errno -2] Name or service not known> compat-golang-github-chzyer-readline-devel.noarch: W: no-documentation compat-golang-github-chzyer-readline-devel.noarch: W: dangling-symlink /usr/share/gocode/src/github.com/chzyer/readline /usr/share/gocode/src/gopkg.in/readline.v1 golang-gopkg-readline-1-devel.noarch: W: invalid-url URL: https://github.com/chzyer/readline <urlopen error [Errno -2] Name or service not known> golang-gopkg-readline-1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/readline.v1/.goipath golang-gopkg-readline-1-devel.noarch: E: zero-length /usr/share/gocode/src/gopkg.in/readline.v1/.goipath 2 packages and 0 specfiles checked; 1 errors, 5 warnings. Requires -------- compat-golang-github-chzyer-readline-devel (rpmlib, GLIBC filtered): golang-ipath(gopkg.in/readline.v1) golang-gopkg-readline-1-devel (rpmlib, GLIBC filtered): Provides -------- compat-golang-github-chzyer-readline-devel: compat-golang-github-chzyer-readline-devel golang(github.com/chzyer/readline) golang(github.com/chzyer/readline/runes) golang-gopkg-readline-1-devel: golang(gopkg.in/readline.v1) golang(gopkg.in/readline.v1/runes) golang-gopkg-readline-1-devel golang-gopkg-readline-devel golang-ipath(gopkg.in/readline.v1) Source checksums ---------------- https://github.com/chzyer/readline/archive/v1.4.tar.gz#/readline-1.4.tar.gz : CHECKSUM(SHA256) this package : 35a66d31d8c91b6b908c40137adf75eac09bb7bd2dbb9dbb12ff74216ec6ba45 CHECKSUM(SHA256) upstream package : 35a66d31d8c91b6b908c40137adf75eac09bb7bd2dbb9dbb12ff74216ec6ba45 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1556636 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-readline-1
golang-gopkg-readline-1-1.4-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-46f209a383
golang-gopkg-readline-1-1.4-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a90c00a7dd
golang-gopkg-readline-1-1.4-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-46f209a383
golang-gopkg-readline-1-1.4-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a90c00a7dd
golang-gopkg-readline-1-1.4-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
golang-gopkg-readline-1-1.4-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
golang-gopkg-readline-1-1.4-4.20180408gitf6d7a1f.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-787cef2bae
golang-gopkg-readline-1-1.4-4.20180408gitf6d7a1f.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-787cef2bae
golang-gopkg-readline-1-1.4-4.20180408gitf6d7a1f.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.