Bug 1559347
| Summary: | [Regression] Infra provider discovery doesn't work | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Antonin Pagac <apagac> | |
| Component: | Providers | Assignee: | Martin Slemr <mslemr> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nikhil Dhandre <ndhandre> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.9.0 | CC: | agrare, cpelland, dmetzger, gblomqui, jfrey, jhardy, lsmola, ndhandre, obarenbo | |
| Target Milestone: | GA | Keywords: | Regression, TestOnly, ZStream | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1566557 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-11 14:07:50 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | VMware | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1566557 | |||
|
Description
Antonin Pagac
2018-03-22 11:08:44 UTC
I haven't looked into rhev but for vmware the ports that we expect are pretty unreliable and change with version and if it is a windows VC or a VCSA appliance. We already get the serviceContent (which you don't need credentials for) here: https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/discovery.rb#L31 So we could completely bypass the port checks and just look at the aboutInfo: vim = MiqVimClientBase.new(ost.ipaddr, "test", "test") vim.sic.about {"name"=>"VMware vCenter Server", "fullName"=>"VMware vCenter Server 5.5.0 build-4180647", "vendor"=>"VMware, Inc.", "version"=>"5.5.0", "build"=>"4180647", "localeVersion"=>"INTL", "localeBuild"=>"000", "osType"=>"linux-x64", "productLineId"=>"vpx", "apiType"=>"VirtualCenter", "apiVersion"=>"5.5", "instanceUuid"=>"2E03442A-8BCC-46D9-B8B5-72C163329D99", "licenseProductName"=>"VMware VirtualCenter Server", "licenseProductVersion"=>"5.0"} Lets focus on vmware in this BZ, RHEV is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1559796 ans will be managed by RHEV team New commits detected on ManageIQ/manageiq-providers-vmware/master: https://github.com/ManageIQ/manageiq-providers-vmware/commit/abe3151a5f14320c0fd6d35cf124c66dd56f5dcb commit abe3151a5f14320c0fd6d35cf124c66dd56f5dcb Author: Martin Slemr <mslemr> AuthorDate: Mon Mar 26 10:21:30 2018 -0400 Commit: Martin Slemr <mslemr> CommitDate: Mon Mar 26 10:21:30 2018 -0400 VMware provider IP discovery fix Recognition of vSphere product based on API info instead ports scanning Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559347 app/models/manageiq/providers/vmware/discovery.rb | 103 +- 1 file changed, 47 insertions(+), 56 deletions(-) https://github.com/ManageIQ/manageiq-providers-vmware/commit/88277fc631027e7b8efa69fdbdaee36c73f83a00 commit 88277fc631027e7b8efa69fdbdaee36c73f83a00 Author: Martin Slemr <mslemr> AuthorDate: Thu Mar 29 05:35:38 2018 -0400 Commit: Martin Slemr <mslemr> CommitDate: Thu Mar 29 05:35:38 2018 -0400 VMWare IP Discovery refactoring Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559347 app/models/manageiq/providers/vmware/discovery.rb | 75 +- 1 file changed, 37 insertions(+), 38 deletions(-) |