Bug 1559347 - [Regression] Infra provider discovery doesn't work
Summary: [Regression] Infra provider discovery doesn't work
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Martin Slemr
QA Contact: Nikhil Dhandre
URL:
Whiteboard:
Depends On:
Blocks: 1566557
TreeView+ depends on / blocked
 
Reported: 2018-03-22 11:08 UTC by Antonin Pagac
Modified: 2019-02-11 14:07 UTC (History)
9 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1566557 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:07:50 UTC
Category: ---
Cloudforms Team: VMware
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1559796 0 high CLOSED [Regression] RHV provider discovery doesn't work 2021-02-22 00:41:40 UTC

Internal Links: 1559796

Description Antonin Pagac 2018-03-22 11:08:44 UTC
Description of problem:
Provider discovery doesn't work for providers:
 - vsphere55, vsphere6, vsphere65
 - rhv41

It seems to be working fine for SCVMM.

Version-Release number of selected component (if applicable):
5.9.2.0

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Compute -> Infrastructure -> Providers
2. Configuration -> Discover Infrastructure Providers
3. Input valid IP range and choose valid provider, click Start

Actual results:
For vsphere, nothing seems to happen. For rhv, an error is thrown in evm.log

Expected results:
Provider discovery successful

Additional info:
Provider discovery works fine for 5.9.1 build.

For vsphere, the discovery process doesn't seem to wait for ping response. Although I can see timeout=10, the command ends milliseconds after it was initiated. This doesn't seem to be the case for the last IP in range.

Comment 6 Adam Grare 2018-03-22 14:06:44 UTC
I haven't looked into rhev but for vmware the ports that we expect are pretty unreliable and change with version and if it is a windows VC or a VCSA appliance.

We already get the serviceContent (which you don't need credentials for) here:
https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/discovery.rb#L31

So we could completely bypass the port checks and just look at the aboutInfo:

vim = MiqVimClientBase.new(ost.ipaddr, "test", "test")
vim.sic.about
{"name"=>"VMware vCenter Server", "fullName"=>"VMware vCenter Server 5.5.0 build-4180647", "vendor"=>"VMware, Inc.", "version"=>"5.5.0", "build"=>"4180647", "localeVersion"=>"INTL", "localeBuild"=>"000", "osType"=>"linux-x64", "productLineId"=>"vpx", "apiType"=>"VirtualCenter", "apiVersion"=>"5.5", "instanceUuid"=>"2E03442A-8BCC-46D9-B8B5-72C163329D99", "licenseProductName"=>"VMware VirtualCenter Server", "licenseProductVersion"=>"5.0"}

Comment 7 Ladislav Smola 2018-03-23 10:18:40 UTC
Lets focus on vmware in this BZ, RHEV is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1559796 ans will be managed by RHEV team

Comment 9 CFME Bot 2018-03-29 14:02:39 UTC
New commits detected on ManageIQ/manageiq-providers-vmware/master:

https://github.com/ManageIQ/manageiq-providers-vmware/commit/abe3151a5f14320c0fd6d35cf124c66dd56f5dcb
commit abe3151a5f14320c0fd6d35cf124c66dd56f5dcb
Author:     Martin Slemr <mslemr>
AuthorDate: Mon Mar 26 10:21:30 2018 -0400
Commit:     Martin Slemr <mslemr>
CommitDate: Mon Mar 26 10:21:30 2018 -0400

    VMware provider IP discovery fix

    Recognition of vSphere product based on API info instead ports scanning

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559347

 app/models/manageiq/providers/vmware/discovery.rb | 103 +-
 1 file changed, 47 insertions(+), 56 deletions(-)


https://github.com/ManageIQ/manageiq-providers-vmware/commit/88277fc631027e7b8efa69fdbdaee36c73f83a00
commit 88277fc631027e7b8efa69fdbdaee36c73f83a00
Author:     Martin Slemr <mslemr>
AuthorDate: Thu Mar 29 05:35:38 2018 -0400
Commit:     Martin Slemr <mslemr>
CommitDate: Thu Mar 29 05:35:38 2018 -0400

    VMWare IP Discovery refactoring

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559347

 app/models/manageiq/providers/vmware/discovery.rb | 75 +-
 1 file changed, 37 insertions(+), 38 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.