Bug 1559417

Summary:	Remove the provisioning namespace safely
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	gowtham <gshanmug>
Component:	web-admin-tendrl-node-agent	Assignee:	gowtham <gshanmug>
Status:	CLOSED ERRATA	QA Contact:	Daniel Horák <dahorak>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.4	CC:	dahorak, gshanmug, mbukatov, nthomas, rhs-bugs
Target Milestone:	---
Target Release:	RHGS 3.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tendrl-node-agent-1.6.1-3.el7rhgs	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-04 07:02:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1503137

Description gowtham 2018-03-22 14:01:30 UTC

Description of problem:

The provisioner namespace in node-agent is not used for a long time, this logic is already handled by some other module, So this namespace should be removed safely without affecting the existing flow.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Martin Bukatovic 2018-03-28 08:47:04 UTC

Could you provide more details about:

* Are you asking us for a code review here?
* Link to upstream merge request.

Comment 3 gowtham 2018-03-28 16:12:59 UTC

Yes, this is also code review only, it is not related to reproducing something, In node-agent a directory called provisioning is not used for a long time. I just removed that directory and I just make sure it is not affecting any functionality.

It is a code review only

Comment 4 Martin Bukatovic 2018-03-29 08:28:59 UTC

Based on your description, I'm providing conditional qe_ack with following
assumptions:

* dev team must have done code review or sanity unit validation of
  the change described in this BZ
* qe team will verify this BZ by running general regression tests

Comment 5 gowtham 2018-03-29 08:34:43 UTC

I agree

Comment 8 Daniel Horák 2018-05-18 08:00:42 UTC

This bug is mentioning "provisioner" namespace, but linked upstream
issue and PR is about "provisioning" namespace.

Also if I read the upstream PR correctly, the "provisioner" namespace is
replacement for the "provisioning" namespace.

@gowtham, If I understand it correctly, could you please update at least the
title of this bug?

Comment 9 gowtham 2018-05-25 11:08:42 UTC

yes daniel your understanding is correct, i will change the titile to provisioning namespace

Comment 10 Daniel Horák 2018-05-28 12:32:42 UTC

The upstream PR is part of the code, no "provisioning" module is present.

# rpm -ql tendrl-node-agent | grep provisioning
# echo $?
  1

Also no relevant issue was found during testing various scenarios in the last days.

Tested and Verified with:
  tendrl-ansible-1.6.3-4.el7rhgs.noarch
  tendrl-api-1.6.3-3.el7rhgs.noarch
  tendrl-api-httpd-1.6.3-3.el7rhgs.noarch
  tendrl-commons-1.6.3-5.el7rhgs.noarch
  tendrl-grafana-plugins-1.6.3-3.el7rhgs.noarch
  tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
  tendrl-monitoring-integration-1.6.3-3.el7rhgs.noarch
  tendrl-node-agent-1.6.3-5.el7rhgs.noarch
  tendrl-notifier-1.6.3-3.el7rhgs.noarch
  tendrl-selinux-1.5.4-2.el7rhgs.noarch
  tendrl-ui-1.6.3-2.el7rhgs.noarch

> VERIFIED

Comment 12 errata-xmlrpc 2018-09-04 07:02:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616