Bug 1559746

Summary:	configshell: Fix targetcli create command for args like "cfgstr,par=val"
Product:	Red Hat Enterprise Linux 7	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	python-configshell	Assignee:	Maurizio Lombardi <mlombard>
Status:	CLOSED ERRATA	QA Contact:	Martin Hoyer <mhoyer>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	7.5	CC:	cww, mhoyer, mlombard, prasanna.kalever, rcyriac
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	Previously, the targetcli utility did not correctly parse command-line options in the "option=value" format or arguments separated by commas. With this update, command-line parsing has been improved, and the options are now recognized correctly.	Story Points:	---
Clone Of:
Clones:	1563298 1566098 (view as bug list)		Environment:
Last Closed:	2018-10-30 07:48:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1535780, 1554642, 1563298, 1566098

Description Prasanna Kumar Kalever 2018-03-23 08:04:36 UTC

Description of problem:

Currently there are parsing errors when trying to create the block with 'max_data_area_mb' option

# targetcli /backstores/user:glfs create name=block size=1073741824 cfgstring=sample.0.104/block-store/3c242959-9238-4ce0-a1ed-19086aa23c7b,max_data_area_mb=16 wwn=3c242959-9238-4ce0-a1ed-19086aa23c7b


Need backport of:
https://github.com/open-iscsi/configshell-fb/pull/36
https://github.com/open-iscsi/configshell-fb/pull/42

Comment 2 Maurizio Lombardi 2018-03-29 15:24:33 UTC

Test package: http://people.redhat.com/~mlombard/.bz1559746/python-configshell-1.1.fb23-4.el7.noarch.rpm

Comment 5 Maurizio Lombardi 2018-04-03 15:17:06 UTC

*** Bug 1563298 has been marked as a duplicate of this bug. ***

Comment 7 Maurizio Lombardi 2018-04-13 07:27:21 UTC

Fixed in package: python-configshell-1.1.fb23-4.el7

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15689206

Comment 8 Martin Hoyer 2018-07-10 10:22:48 UTC

Tested with: 
 - kernel-3.10.0-915.el7
 - targetcli-2.1.fb46-6.el7
 - python-configshell-1.1.fb23-4.el7
 - python-rtslib-2.1.fb63-12.el7
The issue is no longer reproducible; No regression found.

Comment 10 errata-xmlrpc 2018-10-30 07:48:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3025