Bug 1559901

Summary:	Use "integration_id" instead of "cluster_id"
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	gowtham <gshanmug>
Component:	web-admin-tendrl-monitoring-integration	Assignee:	gowtham <gshanmug>
Status:	CLOSED ERRATA	QA Contact:	Daniel Horák <dahorak>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.4	CC:	anbehl, dahorak, gshanmug, mbukatov, nthomas, rhs-bugs
Target Milestone:	---
Target Release:	RHGS 3.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tendrl-monitoring-integration-1.6.1-3.el7rhgs	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-04 07:03:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1503137

Description gowtham 2018-03-23 14:09:14 UTC

Description of problem:

It is seen that many places in monitoring-integration code the term "cluster_id" is used, It should be renamed as "integration_id", there is no such thing as cluster_id.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Martin Bukatovic 2018-03-28 08:35:11 UTC

Could you provide more details about:

* Are you asking us for a code review here?
* Link to upstream merge request.
* Do I understand it right that all occurrences of "cluster_id" should be replaced?
  If not, how should I know which occurrences should be replaced and which not?

Comment 3 gowtham 2018-03-28 16:03:00 UTC

Yes, it is a code review, Inside code, in all tendrl components we used a variable called cluster_id, But there is no cluster_id in tendrl. So a variable "cluster_id" is replaced by a name "integration_id". It just a code change.

Comment 4 Martin Bukatovic 2018-03-29 13:37:00 UTC

I provide conditional qe_ack with following assumptions:

* dev team must have done code walkthrough or sanity unit validation of
  the change described in this BZ
* qe team will verify this BZ by running general regression tests

Nishanth agreed with this solution during "RHGS WA Team status meeting"
on 2018-03-29.

Comment 7 Daniel Horák 2018-05-28 13:17:40 UTC

@gowtham, It looks, like "cluster_id" was replaced in all python files,
but there are number of references in following json files:
  /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-at-a-glance.json
  /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-bricks.json
  /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-hosts.json
  /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-volumes.json

Is this expected, or is there a plan to remove/replace cluster_id reference also
in those json files?

Comment 8 Ankush Behl 2018-06-04 10:25:14 UTC

@dahorak cluster_id is just a variable name used in the dashboard json files to pass the cluster_name and it's an implementation level detail.

The variable name(cluster_id) was introduced when there was not cluster_name property present.

We can do it while refactoring the code also I think these changes are not related to this current issue.

Comment 9 Daniel Horák 2018-06-05 08:28:01 UTC

Verifying on tendrl-monitoring-integration-1.6.3-4.el7rhgs.noarch.
* based on comment 7 and 8.
* and also general regression test cases are passing.

>> VERIFIED

Comment 11 errata-xmlrpc 2018-09-04 07:03:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616