Red Hat Bugzilla – Bug 1559901
Use "integration_id" instead of "cluster_id"
Last modified: 2018-09-04 03:04:26 EDT
Description of problem: It is seen that many places in monitoring-integration code the term "cluster_id" is used, It should be renamed as "integration_id", there is no such thing as cluster_id. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Could you provide more details about: * Are you asking us for a code review here? * Link to upstream merge request. * Do I understand it right that all occurrences of "cluster_id" should be replaced? If not, how should I know which occurrences should be replaced and which not?
Yes, it is a code review, Inside code, in all tendrl components we used a variable called cluster_id, But there is no cluster_id in tendrl. So a variable "cluster_id" is replaced by a name "integration_id". It just a code change.
I provide conditional qe_ack with following assumptions: * dev team must have done code walkthrough or sanity unit validation of the change described in this BZ * qe team will verify this BZ by running general regression tests Nishanth agreed with this solution during "RHGS WA Team status meeting" on 2018-03-29.
@gowtham, It looks, like "cluster_id" was replaced in all python files, but there are number of references in following json files: /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-at-a-glance.json /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-bricks.json /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-hosts.json /etc/tendrl/monitoring-integration/grafana/dashboards/tendrl-gluster-volumes.json Is this expected, or is there a plan to remove/replace cluster_id reference also in those json files?
@dahorak@redhat.com cluster_id is just a variable name used in the dashboard json files to pass the cluster_name and it's an implementation level detail. The variable name(cluster_id) was introduced when there was not cluster_name property present. We can do it while refactoring the code also I think these changes are not related to this current issue.
Verifying on tendrl-monitoring-integration-1.6.3-4.el7rhgs.noarch. * based on comment 7 and 8. * and also general regression test cases are passing. >> VERIFIED
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:2616