Bug 1560916
| Summary: | It is better to set default value for openshift_prometheus_node_exporter_image_version to OCP version | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Junqi Zhao <juzhao> |
| Component: | Installer | Assignee: | Aaron Weitekamp <aweiteka> |
| Status: | CLOSED ERRATA | QA Contact: | Junqi Zhao <juzhao> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.9.0 | CC: | aos-bugs, aweiteka, jokerman, mmariyan, mmccomas, pep, pgier |
| Target Milestone: | --- | ||
| Target Release: | 3.9.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-05-17 06:43:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I believe this is fixed with this PR: https://github.com/openshift/openshift-ansible/pull/7325 https://github.com/openshift/openshift-ansible/pull/7673 to backport to release-3.9 Tested, issue is fixed with the fix in PR This might be a duplicate of bug 1549936... the same fix is referenced there, although there's also an additional discussion about the image's tags themselves. If we should keep this open to track the installer changes vs the other tracking the image tagging, I believe this should be VERIFIED instead based on comment #3. openshift_prometheus_node_exporter_image_version now uses the openshift_image_tag such as image: brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/prometheus-node-exporter:v3.9.22 env # openshift version openshift v3.9.22 kubernetes v1.9.1+a0ce1bc657 etcd 3.2.16 # rpm -qa | grep openshift-ansible openshift-ansible-3.9.22-1.git.0.2e15102.el7.noarch openshift-ansible-roles-3.9.22-1.git.0.2e15102.el7.noarch openshift-ansible-docs-3.9.22-1.git.0.2e15102.el7.noarch openshift-ansible-playbooks-3.9.22-1.git.0.2e15102.el7.noarch # openshift version openshift v3.9.20 kubernetes v1.9.1+a0ce1bc657 etcd 3.2.16 Tested with openshift_prometheus_node_exporter_image_version now uses the openshift_image_tag image: brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/prometheus-node-exporter:v3.9.20 # rpm -qa | grep openshift-ansible openshift-ansible-playbooks-3.9.20-1.git.0.f99fb43.el7.noarch openshift-ansible-3.9.20-1.git.0.f99fb43.el7.noarch openshift-ansible-docs-3.9.20-1.git.0.f99fb43.el7.noarch openshift-ansible-roles-3.9.20-1.git.0.f99fb43.el7.noarch (In reply to Junqi Zhao from comment #7) Change from > Tested with openshift_prometheus_node_exporter_image_version now uses the > openshift_image_tag to Tested with openshift-ansible-roles-3.9.20-1.git.0.f99fb43.el7.noarch, openshift_prometheus_node_exporter_image_version now uses the openshift_image_tag # openshift version openshift v3.9.24 kubernetes v1.9.1+a0ce1bc657 etcd 3.2.16 Tested with openshift_prometheus_node_exporter_image_version now uses the openshift_image_tag image: brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/prometheus-node-exporter:v3.9.24 # rpm -qa | grep openshift-ansible openshift-ansible-playbooks-3.9.24-1.git.0.d0289ea.el7.noarch openshift-ansible-docs-3.9.24-1.git.0.d0289ea.el7.noarch openshift-ansible-roles-3.9.24-1.git.0.d0289ea.el7.noarch openshift-ansible-3.9.24-1.git.0.d0289ea.el7.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1566 |
Description of problem: Default value for openshift_prometheus_node_exporter_image_version is v0.15.2, it is better to set as OCP version, since we release image such images to customer: prometheus-node-exporter:v3.9. Found in stage registry today, prometheus-node-exporter:v3.9 image is pushed to stage repo, but prometheus-node-exporter:v0.15.2 won't push to stage repo, so the prometheus-node-exporter can not be started up. If OCP version is v3.9, set openshift_prometheus_node_exporter_image_version=v3.9 as default version if OCP version is v3.10, set to v3.10 I think we could change settings in roles/openshift_prometheus/vars/openshift-enterprise.yml l_openshift_prometheus_node_exporter_image_version: "{{ openshift_prometheus_node_exporter_image_version | default(openshift_image_tag) }}" Version-Release number of selected component (if applicable): # rpm -qa | grep openshift-ansible openshift-ansible-3.9.14-1.git.0.ca2cfc3.el7.noarch openshift-ansible-roles-3.9.14-1.git.0.ca2cfc3.el7.noarch openshift-ansible-docs-3.9.14-1.git.0.ca2cfc3.el7.noarch openshift-ansible-playbooks-3.9.14-1.git.0.ca2cfc3.el7.noarch How reproducible: Always Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: