Bug 1561483
| Summary: | [downstream clone - 4.1.11] [Labels] - Empty string on label instead of null fails hosted engine setup | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | RHV bug bot <rhv-bugzilla-bot> |
| Component: | ovirt-engine | Assignee: | Eli Mesika <emesika> |
| Status: | CLOSED ERRATA | QA Contact: | Nikolai Sednev <nsednev> |
| Severity: | urgent | Docs Contact: | |
| Priority: | high | ||
| Version: | unspecified | CC: | alkaplan, bugs, cshao, danken, emesika, lrotenbe, lsurette, mavital, mburman, mkalinin, mperina, rbalakri, Rhev-m-bugs, rmcswain, srevivo, tdavis, weiwang, ycui, ykaul, ylavi, yzhao |
| Target Milestone: | ovirt-4.1.11 | Keywords: | Regression, Triaged, ZStream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1560684 | Environment: | |
| Last Closed: | 2018-04-24 15:30:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1560684 | ||
| Bug Blocks: | |||
|
Description
RHV bug bot
2018-03-28 12:25:31 UTC
Created attachment 1413291 [details]
vm engine log
(Originally by Tom Davis)
Created attachment 1413292 [details]
engine server log
(Originally by Tom Davis)
attachment 1413291 [details] and attachment 1413292 [details] seem to contain the same log. Would you attach engine.log from within the VM? Could it be that you specify a network name with a space or another special character? (Originally by danken) Created attachment 1413772 [details]
vm engine log
(Originally by Tom Davis)
I've put the correct vm server log up. I do not specify anything other than what interface to use, hosted-engine --deploy does that.. (Originally by Tom Davis) Also, rc4 worked, rc5 and newer is where this popped up. Is it the engine, or is it hosted-engine --deploy doing the wrong thing? (Originally by Tom Davis) There is no network label being passed in via host-deploy/ansible; from
/usr/share/ovirt-hosted-engine-setup/ansible/bootstrap_local_vm.yml
- name: Set VLAN ID at datacenter level
ovirt_networks:
data_center: "{{ DATA_CENTER }}"
name: "{{ MGMT_NETWORK }}"
vlan_tag: "{{ vlan_id_out.stdout }}"
auth: "{{ ovirt_auth }}"
when: vlan_id_out.stdout|length > 0
is what it is trying to do. Network Label is not supported till ansible 2.5, the hosted-engine deploy uses:
[root@d8-r13-c0-n1 library]# yum list *ansible*
Loaded plugins: fastestmirror, package_upload, product-id, search-disabled-repos, subscription-manager
This system is not registered with an entitlement server. You can use subscription-manager to register.
Loading mirror speeds from cached hostfile
* base: mirrors.usc.edu
* extras: dallas.tx.mirror.xygenhosting.com
* ovirt-4.2: mirrors.ibiblio.org
* ovirt-4.2-epel: mirror.prgmr.com
* updates: mirror.texas3006.com
Installed Packages
ansible.noarch 2.4.2.0-2.el7 @extras
Available Packages
ansible-doc.noarch 2.4.2.0-2.el7 extras
ovirt-ansible-cluster-upgrade.noarch 1.1.6-1.el7.centos ovirt-4.2-pre
ovirt-ansible-disaster-recovery.noarch 0.3-1.el7.centos ovirt-4.2-pre
ovirt-ansible-engine-setup.noarch 1.1.0-1.el7.centos ovirt-4.2
ovirt-ansible-image-template.noarch 1.1.5-1.el7.centos ovirt-4.2
ovirt-ansible-infra.noarch 1.1.4-1.el7.centos ovirt-4.2-pre
ovirt-ansible-manageiq.noarch 1.1.6-1.el7.centos ovirt-4.2-pre
ovirt-ansible-repositories.noarch 1.1.0-1.el7.centos ovirt-4.2
ovirt-ansible-roles.noarch 1.1.3-1.el7.centos ovirt-4.2
ovirt-ansible-vm-infra.noarch 1.1.5-1.el7.centos ovirt-4.2-pre
skydive-ansible.x86_64 0.16.0-1.el7 ovirt-4.2-centos-opstools
so I'm wondering if the engine is complaining about a 'null' or non-existent label?
(Originally by Tom Davis)
The bug was caused by https://gerrit.ovirt.org/#/c/88620/4/packaging/dbscripts/upgrade/04_02_0960_default_all_search_engine_fields_to_empty_string.sql Null and empty labels are treated differently in the code, changing all the nulls to empty strings breaks the functionality. (Originally by Alona Kaplan) (In reply to Alona Kaplan from comment #8) > The bug was caused by > https://gerrit.ovirt.org/#/c/88620/4/packaging/dbscripts/upgrade/ > 04_02_0960_default_all_search_engine_fields_to_empty_string.sql > > Null and empty labels are treated differently in the code, changing all the > nulls to empty strings breaks the functionality. Also, the labels that were changed to be empty should be reverted to be null. (Originally by Alona Kaplan) Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. (Originally by rule-engine) WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason: [Found clone flags: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ] For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason: [Found clone flags: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ] For more info please contact: rhv-devops Removing rhevm-4.2-ga+ flag as the bug was already fixed in oVirt 4.2.2 tracked by BZ1560684 Network update:
- Empty label has gone from the networks in the UI drop down list
- All networks that had the empty label, after upgrade has no label as expected('-' sign in the Label column)
- The empty label gone from the Setup Networks Dialogue -> Labels section
- No regression has caused to network functionality
Tested on - 4.1.11.1-0.1.el7
Verified on: rhvm-appliance-4.1.20180402.0-1.el7.noarch ovirt-hosted-engine-ha-2.1.11-1.el7ev.noarch ovirt-hosted-engine-setup-2.1.4.2-1.el7ev.noarch Red Hat Enterprise Linux Server release 7.5 (Maipo) Engine inside the appliance: ovirt-engine-setup-base-4.1.10.3-0.1.el7.noarch Deployed over NFS. Deployment passed. Hi Liran, Few notes: 1) You not testing the correct engine version(should be tested on 4.1.11), we don't have such appliance yet available for QE 2) The HE deploy should be tested over a vlan tagged interface as Nikolai did on 4.2(it was failing over a vlan interface) Moving back to ON_QA Successfully deployed over tagged VLAN 404. ovirt-hosted-engine-setup-2.1.4.2-1.el7ev.noarch ovirt-hosted-engine-ha-2.1.11-1.el7ev.noarch rhvm-appliance-4.1.20180419.0-1.el7.noarch ovirt-engine-setup-4.1.11.2-0.1.el7.noarch Linux 3.10.0-862.el7.x86_64 #1 SMP Wed Mar 21 18:14:51 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux Server release 7.5 (Maipo) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1219 BZ<2>Jira Resync |