Bug 1561483 - [downstream clone - 4.1.11] [Labels] - Empty string on label instead of null fails hosted engine setup
Summary: [downstream clone - 4.1.11] [Labels] - Empty string on label instead of null ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: unspecified
Hardware: x86_64
OS: Linux
high
urgent
Target Milestone: ovirt-4.1.11
: ---
Assignee: Eli Mesika
QA Contact: Nikolai Sednev
URL:
Whiteboard:
Depends On: 1560684
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-28 12:25 UTC by RHV bug bot
Modified: 2019-05-16 13:07 UTC (History)
21 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1560684
Environment:
Last Closed: 2018-04-24 15:30:28 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 3396091 0 None None None 2018-03-29 21:57:10 UTC
Red Hat Product Errata RHBA-2018:1219 0 None None None 2018-04-24 15:31:17 UTC
oVirt gerrit 89553 0 master MERGED core: setting network label to NULL 2018-03-28 14:36:40 UTC
oVirt gerrit 89556 0 ovirt-engine-4.1 MERGED core: setting network label to NULL 2018-03-28 18:06:32 UTC
oVirt gerrit 89609 0 ovirt-engine-4.1.10.z MERGED core: setting network label to NULL 2018-03-29 13:49:00 UTC

Description RHV bug bot 2018-03-28 12:25:31 UTC
+++ This bug is an upstream to downstream clone. The original bug is: +++
+++   bug 1560684 +++
======================================================================

Created attachment 1413290 [details]
hosted-engine log

Description of problem:

[ INFO  ] TASK [Enable GlusterFS at cluster level]
[ INFO  ] skipping: [localhost]
[ INFO  ] TASK [Set VLAN ID at datacenter level]
[ ERROR ] Error: Fault reason is "Operation Failed". Fault detail is "[Network label must be formed only from: English letters, numbers, hyphen or underscore., Attribute: network.label]". HTTP response code is 400.
[ ERROR ] fatal: [localhost]: FAILED! => {"changed": false, "msg": "Fault reason is \"Operation Failed\". Fault detail is \"[Network label must be formed only from: English letters, numbers, hyphen or underscore., Attribute: network.label]\". HTTP response code is 400."}
[ INFO  ] TASK [include_tasks]
[ INFO  ] ok: [localhost]
[ INFO  ] TASK [Remove local vm dir]
[ INFO  ] changed: [localhost]
[ INFO  ] TASK [Notify the user about a failure]
[ ERROR ] fatal: [localhost]: FAILED! => {"changed": false, "msg": "The system may not be provisioned according to the playbook results: please check the logs for the issue, fix accordingly or re-deploy from scratch.\n"}
[ ERROR ] Failed to execute stage 'Closing up': Failed executing ansible-playbook
[ INFO  ] Stage: Clean up
[ INFO  ] Cleaning temporary resources
[ INFO  ] TASK [Gathering Facts]
[ INFO  ] ok: [localhost]
[ INFO  ] TASK [include_tasks]
[ INFO  ] ok: [localhost]
[ INFO  ] TASK [Remove local vm dir]
[ INFO  ] ok: [localhost]
[ INFO  ] Generating answer file '/var/lib/ovirt-hosted-engine-setup/answers/answers-20180326111210.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Hosted Engine deployment failed: please check the logs for the issue, fix accordingly or re-deploy from scratch.
          Log file is located at /var/log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-20180326110506-6ga7ie.log


Version-Release number of selected component (if applicable):

ovirt-engine-appliance.noarch                                   4.2-20180321.1.el7.centos                                   @ovirt-4.2-pre
ovirt-engine-sdk-python.noarch                                  3.6.9.1-1.el7                                               @ovirt-4.2
ovirt-host.x86_64                                               4.2.2-2.el7.centos                                          @ovirt-4.2-pre
ovirt-host-dependencies.x86_64                                  4.2.2-2.el7.centos                                          @ovirt-4.2-pre
ovirt-host-deploy.noarch                                        1.7.3-1.el7.centos                                          @ovirt-4.2-pre
ovirt-hosted-engine-ha.noarch                                   2.2.8-1.el7.centos                                          @ovirt-4.2-pre
ovirt-hosted-engine-setup.noarch                                2.2.15-1.el7.centos                                         @ovirt-4.2-pre
ovirt-imageio-common.noarch                                     1.2.2-0.el7.centos                                          @ovirt-4.2-pre
ovirt-imageio-daemon.noarch                                     1.2.2-0.el7.centos                                          @ovirt-4.2-pre
ovirt-provider-ovn-driver.noarch                                1.2.9-1.el7.centos                                          @ovirt-4.2-pre
ovirt-release42-pre.noarch                                      4.2.2-0.6.rc6.20180326144545.git9bcecfa.el7.centos          @ovirt-4.2-pre
ovirt-setup-lib.noarch                                          1.1.4-1.el7.centos                                          @ovirt-4.2
ovirt-vmconsole.noarch                                          1.0.4-1.el7                                                 @ovirt-4.2
ovirt-vmconsole-host.noarch                                     1.0.4-1.el7                                                 @ovirt-4.2


How reproducible:

everytime.

Steps to Reproduce:
1.  yum install release candidate hosted-engine rpm.
2.  hosted-engine --deploy
3.

Actual results:

Failure.

Expected results:

Complete and running oVirt hosted-engine.

Additional info:

(Originally by Tom Davis)

Comment 1 RHV bug bot 2018-03-28 12:25:42 UTC
Created attachment 1413291 [details]
vm engine log

(Originally by Tom Davis)

Comment 3 RHV bug bot 2018-03-28 12:25:49 UTC
Created attachment 1413292 [details]
engine server log

(Originally by Tom Davis)

Comment 4 RHV bug bot 2018-03-28 12:25:56 UTC
attachment 1413291 [details] and attachment 1413292 [details] seem to contain the same log. Would you attach engine.log from within the VM?

Could it be that you specify a network name with a space or another special character?

(Originally by danken)

Comment 5 RHV bug bot 2018-03-28 12:26:02 UTC
Created attachment 1413772 [details]
vm engine log

(Originally by Tom Davis)

Comment 6 RHV bug bot 2018-03-28 12:26:09 UTC
I've put the correct vm server log up.

I do not specify anything other than what interface to use, hosted-engine --deploy does that..

(Originally by Tom Davis)

Comment 7 RHV bug bot 2018-03-28 12:26:16 UTC
Also, rc4 worked, rc5 and newer is where this popped up.

Is it the engine, or is it hosted-engine --deploy doing the wrong thing?

(Originally by Tom Davis)

Comment 8 RHV bug bot 2018-03-28 12:26:22 UTC
There is no network label being passed in via host-deploy/ansible; from

/usr/share/ovirt-hosted-engine-setup/ansible/bootstrap_local_vm.yml


      - name: Set VLAN ID at datacenter level
        ovirt_networks:
          data_center: "{{ DATA_CENTER }}"
          name: "{{ MGMT_NETWORK }}"
          vlan_tag: "{{ vlan_id_out.stdout }}"
          auth: "{{ ovirt_auth }}"
        when: vlan_id_out.stdout|length > 0

is what it is trying to do.  Network Label is not supported till ansible 2.5, the hosted-engine deploy uses:

[root@d8-r13-c0-n1 library]# yum list *ansible*
Loaded plugins: fastestmirror, package_upload, product-id, search-disabled-repos, subscription-manager
This system is not registered with an entitlement server. You can use subscription-manager to register.
Loading mirror speeds from cached hostfile
 * base: mirrors.usc.edu
 * extras: dallas.tx.mirror.xygenhosting.com
 * ovirt-4.2: mirrors.ibiblio.org
 * ovirt-4.2-epel: mirror.prgmr.com
 * updates: mirror.texas3006.com
Installed Packages
ansible.noarch                                                             2.4.2.0-2.el7                                          @extras                  
Available Packages
ansible-doc.noarch                                                         2.4.2.0-2.el7                                          extras                   
ovirt-ansible-cluster-upgrade.noarch                                       1.1.6-1.el7.centos                                     ovirt-4.2-pre            
ovirt-ansible-disaster-recovery.noarch                                     0.3-1.el7.centos                                       ovirt-4.2-pre            
ovirt-ansible-engine-setup.noarch                                          1.1.0-1.el7.centos                                     ovirt-4.2                
ovirt-ansible-image-template.noarch                                        1.1.5-1.el7.centos                                     ovirt-4.2                
ovirt-ansible-infra.noarch                                                 1.1.4-1.el7.centos                                     ovirt-4.2-pre            
ovirt-ansible-manageiq.noarch                                              1.1.6-1.el7.centos                                     ovirt-4.2-pre            
ovirt-ansible-repositories.noarch                                          1.1.0-1.el7.centos                                     ovirt-4.2                
ovirt-ansible-roles.noarch                                                 1.1.3-1.el7.centos                                     ovirt-4.2                
ovirt-ansible-vm-infra.noarch                                              1.1.5-1.el7.centos                                     ovirt-4.2-pre            
skydive-ansible.x86_64                                                     0.16.0-1.el7                                           ovirt-4.2-centos-opstools

so I'm wondering if the engine is complaining about a 'null' or non-existent label?

(Originally by Tom Davis)

Comment 9 RHV bug bot 2018-03-28 12:26:30 UTC
The bug was caused by https://gerrit.ovirt.org/#/c/88620/4/packaging/dbscripts/upgrade/04_02_0960_default_all_search_engine_fields_to_empty_string.sql

Null and empty labels are treated differently in the code, changing all the nulls to empty strings breaks the functionality.

(Originally by Alona Kaplan)

Comment 10 RHV bug bot 2018-03-28 12:26:37 UTC
(In reply to Alona Kaplan from comment #8)
> The bug was caused by
> https://gerrit.ovirt.org/#/c/88620/4/packaging/dbscripts/upgrade/
> 04_02_0960_default_all_search_engine_fields_to_empty_string.sql
> 
> Null and empty labels are treated differently in the code, changing all the
> nulls to empty strings breaks the functionality.

Also, the labels that were changed to be empty should be reverted to be null.

(Originally by Alona Kaplan)

Comment 11 RHV bug bot 2018-03-28 12:26:44 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

(Originally by rule-engine)

Comment 14 RHV bug bot 2018-04-11 16:57:04 UTC
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found clone flags: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found clone flags: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ]

For more info please contact: rhv-devops

Comment 15 Martin Perina 2018-04-11 17:56:23 UTC
Removing rhevm-4.2-ga+ flag as the bug was already fixed in oVirt 4.2.2 tracked by BZ1560684

Comment 17 Michael Burman 2018-04-15 13:41:48 UTC
Network update:
- Empty label has gone from the networks in the UI drop down list
- All networks that had the empty label, after upgrade has no label as expected('-' sign in the Label column)
- The empty label gone from the Setup Networks Dialogue -> Labels section
- No regression has caused to network functionality

Tested on - 4.1.11.1-0.1.el7

Comment 18 Liran Rotenberg 2018-04-17 12:02:20 UTC
Verified on:
rhvm-appliance-4.1.20180402.0-1.el7.noarch
ovirt-hosted-engine-ha-2.1.11-1.el7ev.noarch
ovirt-hosted-engine-setup-2.1.4.2-1.el7ev.noarch
Red Hat Enterprise Linux Server release 7.5 (Maipo)

Engine inside the appliance:
ovirt-engine-setup-base-4.1.10.3-0.1.el7.noarch

Deployed over NFS.

Deployment passed.

Comment 19 Michael Burman 2018-04-17 12:14:34 UTC
Hi Liran,

Few notes:
1) You not testing the correct engine version(should be tested on 4.1.11), we don't have such appliance yet available for QE
2) The HE deploy should be tested over a vlan tagged interface as Nikolai did on 4.2(it was failing over a vlan interface)
Moving back to ON_QA

Comment 22 Nikolai Sednev 2018-04-23 16:17:41 UTC
Successfully deployed over tagged VLAN 404.
ovirt-hosted-engine-setup-2.1.4.2-1.el7ev.noarch
ovirt-hosted-engine-ha-2.1.11-1.el7ev.noarch
rhvm-appliance-4.1.20180419.0-1.el7.noarch
ovirt-engine-setup-4.1.11.2-0.1.el7.noarch
Linux 3.10.0-862.el7.x86_64 #1 SMP Wed Mar 21 18:14:51 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux
Red Hat Enterprise Linux Server release 7.5 (Maipo)

Comment 25 errata-xmlrpc 2018-04-24 15:30:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1219

Comment 26 Franta Kust 2019-05-16 13:07:07 UTC
BZ<2>Jira Resync


Note You need to log in before you can comment on or make changes to this bug.