Red Hat Bugzilla – Bug 1561483
[downstream clone - 4.1.11] [Labels] - Empty string on label instead of null fails hosted engine setup
Last modified: 2018-04-24 11:31:18 EDT
+++ This bug is an upstream to downstream clone. The original bug is: +++ +++ bug 1560684 +++ ====================================================================== Created attachment 1413290 [details] hosted-engine log Description of problem: [ INFO ] TASK [Enable GlusterFS at cluster level] [ INFO ] skipping: [localhost] [ INFO ] TASK [Set VLAN ID at datacenter level] [ ERROR ] Error: Fault reason is "Operation Failed". Fault detail is "[Network label must be formed only from: English letters, numbers, hyphen or underscore., Attribute: network.label]". HTTP response code is 400. [ ERROR ] fatal: [localhost]: FAILED! => {"changed": false, "msg": "Fault reason is \"Operation Failed\". Fault detail is \"[Network label must be formed only from: English letters, numbers, hyphen or underscore., Attribute: network.label]\". HTTP response code is 400."} [ INFO ] TASK [include_tasks] [ INFO ] ok: [localhost] [ INFO ] TASK [Remove local vm dir] [ INFO ] changed: [localhost] [ INFO ] TASK [Notify the user about a failure] [ ERROR ] fatal: [localhost]: FAILED! => {"changed": false, "msg": "The system may not be provisioned according to the playbook results: please check the logs for the issue, fix accordingly or re-deploy from scratch.\n"} [ ERROR ] Failed to execute stage 'Closing up': Failed executing ansible-playbook [ INFO ] Stage: Clean up [ INFO ] Cleaning temporary resources [ INFO ] TASK [Gathering Facts] [ INFO ] ok: [localhost] [ INFO ] TASK [include_tasks] [ INFO ] ok: [localhost] [ INFO ] TASK [Remove local vm dir] [ INFO ] ok: [localhost] [ INFO ] Generating answer file '/var/lib/ovirt-hosted-engine-setup/answers/answers-20180326111210.conf' [ INFO ] Stage: Pre-termination [ INFO ] Stage: Termination [ ERROR ] Hosted Engine deployment failed: please check the logs for the issue, fix accordingly or re-deploy from scratch. Log file is located at /var/log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-20180326110506-6ga7ie.log Version-Release number of selected component (if applicable): ovirt-engine-appliance.noarch 4.2-20180321.1.el7.centos @ovirt-4.2-pre ovirt-engine-sdk-python.noarch 3.6.9.1-1.el7 @ovirt-4.2 ovirt-host.x86_64 4.2.2-2.el7.centos @ovirt-4.2-pre ovirt-host-dependencies.x86_64 4.2.2-2.el7.centos @ovirt-4.2-pre ovirt-host-deploy.noarch 1.7.3-1.el7.centos @ovirt-4.2-pre ovirt-hosted-engine-ha.noarch 2.2.8-1.el7.centos @ovirt-4.2-pre ovirt-hosted-engine-setup.noarch 2.2.15-1.el7.centos @ovirt-4.2-pre ovirt-imageio-common.noarch 1.2.2-0.el7.centos @ovirt-4.2-pre ovirt-imageio-daemon.noarch 1.2.2-0.el7.centos @ovirt-4.2-pre ovirt-provider-ovn-driver.noarch 1.2.9-1.el7.centos @ovirt-4.2-pre ovirt-release42-pre.noarch 4.2.2-0.6.rc6.20180326144545.git9bcecfa.el7.centos @ovirt-4.2-pre ovirt-setup-lib.noarch 1.1.4-1.el7.centos @ovirt-4.2 ovirt-vmconsole.noarch 1.0.4-1.el7 @ovirt-4.2 ovirt-vmconsole-host.noarch 1.0.4-1.el7 @ovirt-4.2 How reproducible: everytime. Steps to Reproduce: 1. yum install release candidate hosted-engine rpm. 2. hosted-engine --deploy 3. Actual results: Failure. Expected results: Complete and running oVirt hosted-engine. Additional info: (Originally by Tom Davis)
Created attachment 1413291 [details] vm engine log (Originally by Tom Davis)
Created attachment 1413292 [details] engine server log (Originally by Tom Davis)
attachment 1413291 [details] and attachment 1413292 [details] seem to contain the same log. Would you attach engine.log from within the VM? Could it be that you specify a network name with a space or another special character? (Originally by danken)
Created attachment 1413772 [details] vm engine log (Originally by Tom Davis)
I've put the correct vm server log up. I do not specify anything other than what interface to use, hosted-engine --deploy does that.. (Originally by Tom Davis)
Also, rc4 worked, rc5 and newer is where this popped up. Is it the engine, or is it hosted-engine --deploy doing the wrong thing? (Originally by Tom Davis)
There is no network label being passed in via host-deploy/ansible; from /usr/share/ovirt-hosted-engine-setup/ansible/bootstrap_local_vm.yml - name: Set VLAN ID at datacenter level ovirt_networks: data_center: "{{ DATA_CENTER }}" name: "{{ MGMT_NETWORK }}" vlan_tag: "{{ vlan_id_out.stdout }}" auth: "{{ ovirt_auth }}" when: vlan_id_out.stdout|length > 0 is what it is trying to do. Network Label is not supported till ansible 2.5, the hosted-engine deploy uses: [root@d8-r13-c0-n1 library]# yum list *ansible* Loaded plugins: fastestmirror, package_upload, product-id, search-disabled-repos, subscription-manager This system is not registered with an entitlement server. You can use subscription-manager to register. Loading mirror speeds from cached hostfile * base: mirrors.usc.edu * extras: dallas.tx.mirror.xygenhosting.com * ovirt-4.2: mirrors.ibiblio.org * ovirt-4.2-epel: mirror.prgmr.com * updates: mirror.texas3006.com Installed Packages ansible.noarch 2.4.2.0-2.el7 @extras Available Packages ansible-doc.noarch 2.4.2.0-2.el7 extras ovirt-ansible-cluster-upgrade.noarch 1.1.6-1.el7.centos ovirt-4.2-pre ovirt-ansible-disaster-recovery.noarch 0.3-1.el7.centos ovirt-4.2-pre ovirt-ansible-engine-setup.noarch 1.1.0-1.el7.centos ovirt-4.2 ovirt-ansible-image-template.noarch 1.1.5-1.el7.centos ovirt-4.2 ovirt-ansible-infra.noarch 1.1.4-1.el7.centos ovirt-4.2-pre ovirt-ansible-manageiq.noarch 1.1.6-1.el7.centos ovirt-4.2-pre ovirt-ansible-repositories.noarch 1.1.0-1.el7.centos ovirt-4.2 ovirt-ansible-roles.noarch 1.1.3-1.el7.centos ovirt-4.2 ovirt-ansible-vm-infra.noarch 1.1.5-1.el7.centos ovirt-4.2-pre skydive-ansible.x86_64 0.16.0-1.el7 ovirt-4.2-centos-opstools so I'm wondering if the engine is complaining about a 'null' or non-existent label? (Originally by Tom Davis)
The bug was caused by https://gerrit.ovirt.org/#/c/88620/4/packaging/dbscripts/upgrade/04_02_0960_default_all_search_engine_fields_to_empty_string.sql Null and empty labels are treated differently in the code, changing all the nulls to empty strings breaks the functionality. (Originally by Alona Kaplan)
(In reply to Alona Kaplan from comment #8) > The bug was caused by > https://gerrit.ovirt.org/#/c/88620/4/packaging/dbscripts/upgrade/ > 04_02_0960_default_all_search_engine_fields_to_empty_string.sql > > Null and empty labels are treated differently in the code, changing all the > nulls to empty strings breaks the functionality. Also, the labels that were changed to be empty should be reverted to be null. (Originally by Alona Kaplan)
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. (Originally by rule-engine)
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason: [Found clone flags: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ] For more info please contact: rhv-devops@redhat.comINFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason: [Found clone flags: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ] For more info please contact: rhv-devops@redhat.com
Removing rhevm-4.2-ga+ flag as the bug was already fixed in oVirt 4.2.2 tracked by BZ1560684
Network update: - Empty label has gone from the networks in the UI drop down list - All networks that had the empty label, after upgrade has no label as expected('-' sign in the Label column) - The empty label gone from the Setup Networks Dialogue -> Labels section - No regression has caused to network functionality Tested on - 4.1.11.1-0.1.el7
Verified on: rhvm-appliance-4.1.20180402.0-1.el7.noarch ovirt-hosted-engine-ha-2.1.11-1.el7ev.noarch ovirt-hosted-engine-setup-2.1.4.2-1.el7ev.noarch Red Hat Enterprise Linux Server release 7.5 (Maipo) Engine inside the appliance: ovirt-engine-setup-base-4.1.10.3-0.1.el7.noarch Deployed over NFS. Deployment passed.
Hi Liran, Few notes: 1) You not testing the correct engine version(should be tested on 4.1.11), we don't have such appliance yet available for QE 2) The HE deploy should be tested over a vlan tagged interface as Nikolai did on 4.2(it was failing over a vlan interface) Moving back to ON_QA
Successfully deployed over tagged VLAN 404. ovirt-hosted-engine-setup-2.1.4.2-1.el7ev.noarch ovirt-hosted-engine-ha-2.1.11-1.el7ev.noarch rhvm-appliance-4.1.20180419.0-1.el7.noarch ovirt-engine-setup-4.1.11.2-0.1.el7.noarch Linux 3.10.0-862.el7.x86_64 #1 SMP Wed Mar 21 18:14:51 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux Server release 7.5 (Maipo)
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1219