Bug 1561544

Summary: Splitstack deployment fails due to the bug in get-occ-config.sh script
Product: Red Hat OpenStack Reporter: Gurenko Alex <agurenko>
Component: openstack-tripleo-heat-templatesAssignee: James Slagle <jslagle>
Status: CLOSED ERRATA QA Contact: Gurenko Alex <agurenko>
Severity: high Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: aschultz, emacchi, jcoufal, jschluet, mburns, rhel-osp-director-maint
Target Milestone: betaKeywords: Triaged
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-8.0.2-0.20180327213844.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-27 13:49:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gurenko Alex 2018-03-28 14:08:30 UTC 
Description of problem: when get-occ-config.sh script runs, it only updates first node and exits with rc 0.


Version-Release number of selected component (if applicable): OSP13


How reproducible: 100%


Steps to Reproduce:
1. Follow split stack deployment path
2. run heat-admin.sh that triggers get-occ-config.sh
3. start overcloud_deploy.sh

Actual results: Deployment fails with a timeout


Expected results: Deployment succeed


Additional info:

get-occ-config.sh contains ((i++)) at line 160 and needs to be reverted to i+=1 which was introduced by following commit: https://code.engineering.redhat.com/gerrit/gitweb?p=openstack-tripleo-heat-templates.git;a=commitdiff;h=f17b0a14dad89fdb0594457b602d4ca183b230d7
Comment 1 James Slagle 2018-03-28 14:21:06 UTC 
sample log:
https://pastebin.com/kn6Q8TSJ

notice how the script just exits after ((i++)) even though there were multiple stacks in the $stacks var.

This is because the bash expression ((i++)) evaluates to 0, so returns 1, causing the script to exit.

We need to revert this line back to let i+=1
Comment 6 Gurenko Alex 2018-04-11 11:45:38 UTC 
[stack@undercloud-0 ~]$ cat core_puddle_version
2018-04-10.2
[stack@undercloud-0 ~]$ rpm -q openstack-tripleo-heat-templates
openstack-tripleo-heat-templates-8.0.2-0.20180327213846.el7ost.noarch
Comment 8 errata-xmlrpc 2018-06-27 13:49:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2086