Bug 1561757

Summary: Review Request: golang-github-dsnet-compress - Collection of compression related Go packages
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-12 07:51:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1376749, 1561203, 1561349, 1564272    
Bug Blocks: 1561759    

Description Dominik 'Rathann' Mierzejewski 2018-03-28 20:14:15 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-github-dsnet-compress/golang-github-dsnet-compress.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-dsnet-compress/golang-github-dsnet-compress-0-0.1.20180326gitcc9eb1d.fc27.src.rpm
Description:
This repository hosts a collection of compression related libraries. The goal of
this project is to provide pure Go implementations for popular compression
algorithms beyond what the Go standard library provides. The goals for these
packages are as follows:
* Maintainable: That the code remains well documented, well tested, readable,
  easy to maintain, and easy to verify that it conforms to the specification
  for the format being implemented.
* Performant: To be able to compress and decompress within at least 80% of the
  rates that the C implementations are able to achieve.
* Flexible: That the code provides low-level and fine granularity control over
  the compression streams similar to what the C APIs would provide.

Of these three, the first objective is often at odds with the other two
objectives and provides interesting challenges. Higher performance can often be
achieved by muddling abstraction layers or using non-intuitive low-level
primitives. Also, more features and functionality, while useful in some
situations, often complicates the API. Thus, this package will attempt to
satisfy all the goals, but will defer to favoring maintainability when the
performance or flexibility benefits are not significant enough.

Fedora Account System Username: rathann

Comment 1 Dominik 'Rathann' Mierzejewski 2018-03-28 20:15:41 UTC
COPR repo: https://copr.fedorainfracloud.org/coprs/rathann/jfrog-cli/ .

Comment 2 Robert-André Mauchin 🐧 2018-03-28 20:49:17 UTC
 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines


   Split the doc into a noarch subpackage:

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 11939840 bytes in 27 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Comment 3 Dominik 'Rathann' Mierzejewski 2018-03-28 21:48:40 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-github-dsnet-compress/golang-github-dsnet-compress.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-dsnet-compress/golang-github-dsnet-compress-0-0.2.20180326gitcc9eb1d.fc27.src.rpm

* Wed Mar 28 2018 Dominik Mierzejewski <dominik> - 0-0.2.20180326gitcc9eb1d
- split docs into a separate subpackage

Comment 4 Robert-André Mauchin 🐧 2018-03-28 21:52:25 UTC
Package approved.

Comment 5 Gwyn Ciesla 2018-03-29 15:15:10 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dsnet-compress

Comment 6 Dominik 'Rathann' Mierzejewski 2018-04-12 07:51:37 UTC
Imported and built for rawhide. Thanks for the review.