Spec URL: https://mrunge.fedorapeople.org/reviews/golang-github-klauspost-compress/golang-github-klauspost-compress.spec SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-klauspost-compress/golang-github-klauspost-compress-0-0.1.git7b02889.fc24.src.rpm Description: Optimized compression packages Fedora Account System Username: mrunge $ rpmlint golang-github-klauspost-compress-0-0.1.git7b02889.fc24.src.rpm golang-github-klauspost-compress-devel-0-0.1.git7b02889.fc24.noarch.rpm golang-github-klauspost-compress-unit-test-devel-0-0.1.git7b02889.fc24.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
- Please use the latest release https://github.com/klauspost/compress/releases %global commit 6c8db69c4b49dd4df1fff66996cf556176d0b9bf %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate 20170114 Name: golang-%{provider}-%{project}-%{repo} Version: 1.2.1 Release: 1%{?dist} And: * Sun Oct 01 2017 Matthias Runge <mrunge> - 1.2.1-1 - Please also fix: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-klauspost-compress-devel/README.md Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 144 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/golang-github-klauspost-compress/review- golang-github-klauspost-compress/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/klauspost(golang-github-klauspost- cpuid-devel, golang-github-klauspost-crc32-devel, golang-github- klauspost-reedsolomon-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-klauspost-compress-devel , golang-github-klauspost-compress- unit-test-devel [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-klauspost-compress-devel-1.2.1-1.fc28.noarch.rpm golang-github-klauspost-compress-unit-test-devel-1.2.1-1.fc28.x86_64.rpm golang-github-klauspost-compress-1.2.1-1.fc28.src.rpm golang-github-klauspost-compress-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-klauspost-compress-devel/README.md golang-github-klauspost-compress-unit-test-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-klauspost-compress-unit-test-devel/README.md 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory golang-github-klauspost-compress-devel.noarch: W: invalid-url URL: https://github.com/klauspost/compress <urlopen error [Errno -2] Name or service not known> golang-github-klauspost-compress-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-klauspost-compress-devel/README.md golang-github-klauspost-compress-unit-test-devel.x86_64: W: invalid-url URL: https://github.com/klauspost/compress <urlopen error [Errno -2] Name or service not known> golang-github-klauspost-compress-unit-test-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-klauspost-compress-unit-test-devel/README.md 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
FYI, testsuite will fail if you don't apply https://github.com/klauspost/compress/commit/b88785bfd699aa994985ea91b90ee8a1721c3fe1 . Also, it might be worth it to apply https://github.com/klauspost/compress/commit/e80ca55b53e5e6f53deed5c7842e7b7da95e1dc7 as well, to reduce dependencies, because current Fedora and EPEL ship golang 1.8+.
Created attachment 1413093 [details] alternative spec file Attaching my spec made using https://fedoraproject.org/wiki/More_Go_packaging for reference. Feel free to use it.
Updated my spec with the patches mentioned in comment 2 applied: Spec URL: https://rathann.fedorapeople.org/review/golang-github-klauspost-compress/golang-github-klauspost-compress.spec SRPM URL: https://rathann.fedorapeople.org/review/golang-github-klauspost-compress/golang-github-klauspost-compress-1.2.1-1.fc27.src.rpm I'd say it's a very good idea to apply those two, because then you can run the test suite without circular dependencies (i.e. it builds against current rawhide). I can submit a new review request if there's no response from Matthias, but I'm not really fond of maintaining this as it's only a dependency of another package.
I'm sorry to keep you waiting here. I'm currently on vacation, and will be back after Easter. This is a dependency for a package of mine. Dominik, thank you for your suggestions, I'll have a look asap. Robert-André, thank you for your review, and sorry for not responding sooner. I'll address the issues, once I'm back.
I'd appreciate if you use the new Go packaging as Dominik suggested, your package was the last I reviewed in the old guidelines style. Please read https://fedoraproject.org/wiki/More_Go_packaging and ask any questions that might arise.
Since my attention completely shifted away, I realized, that I currently don't have the time to continue here. Upstream added another package as dependency for the most recent version. I'm sorry, I need to drop this. Any of you want to take over?
Sure thing, new review submitted as bug 1564272.