Bug 1562840

Summary: Review Request: golang-gopkg-warnings - Error handling with non-fatal errors (warnings)
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-03 00:12:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1562941    

Description Dominik 'Rathann' Mierzejewski 2018-04-02 16:53:43 UTC 
Spec URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings-0/golang-gopkg-warnings-0.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings-0/golang-gopkg-warnings-0-0.1.2-1.fc27.src.rpm
Description:
A recurring programming pattern pattern is to allow interrupting the flow on any
received error. But what if there are errors that should be noted but still not
fatal, for which the flow should not be interrupted? Implementing such logic at
each if statement would make the code complex and the flow much harder to
follow.

Package warnings provides the Collector type and a clean and simple pattern for
achieving such logic. The Collector takes care of deciding when to break the
flow and when to continue, collecting any non-fatal errors (warnings) along the
way. The only requirement is that fatal and non-fatal errors can be
distinguished programmatically.

Fedora Account System Username: rathann
Comment 1 Dominik 'Rathann' Mierzejewski 2018-04-02 17:09:00 UTC 
Spec URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings/golang-gopkg-warnings.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings/golang-gopkg-warnings-0.1.2-1.fc27.src.rpm

Dropped -0 from package name, this is the latest (and only) version.
Comment 2 Robert-André Mauchin 🐧 2018-04-02 22:11:58 UTC 
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.
Comment 3 Jason Tibbitts 2018-04-02 23:50:47 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-warnings
Comment 4 Dominik 'Rathann' Mierzejewski 2018-04-03 00:12:33 UTC 
Imported and built for rawhide. Thanks for the review!