Bug 1562840 - Review Request: golang-gopkg-warnings - Error handling with non-fatal errors (warnings)
Summary: Review Request: golang-gopkg-warnings - Error handling with non-fatal errors ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1562941
TreeView+ depends on / blocked
 
Reported: 2018-04-02 16:53 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2018-04-03 00:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-04-03 00:12:33 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2018-04-02 16:53:43 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings-0/golang-gopkg-warnings-0.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings-0/golang-gopkg-warnings-0-0.1.2-1.fc27.src.rpm
Description:
A recurring programming pattern pattern is to allow interrupting the flow on any
received error. But what if there are errors that should be noted but still not
fatal, for which the flow should not be interrupted? Implementing such logic at
each if statement would make the code complex and the flow much harder to
follow.

Package warnings provides the Collector type and a clean and simple pattern for
achieving such logic. The Collector takes care of deciding when to break the
flow and when to continue, collecting any non-fatal errors (warnings) along the
way. The only requirement is that fatal and non-fatal errors can be
distinguished programmatically.

Fedora Account System Username: rathann

Comment 1 Dominik 'Rathann' Mierzejewski 2018-04-02 17:09:00 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings/golang-gopkg-warnings.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-gopkg-warnings/golang-gopkg-warnings-0.1.2-1.fc27.src.rpm

Dropped -0 from package name, this is the latest (and only) version.

Comment 2 Robert-André Mauchin 🐧 2018-04-02 22:11:58 UTC
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 3 Jason Tibbitts 2018-04-02 23:50:47 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-warnings

Comment 4 Dominik 'Rathann' Mierzejewski 2018-04-03 00:12:33 UTC
Imported and built for rawhide. Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.