Bug 1562941

Summary: Review Request: golang-github-src-d-gcfg - Read INI-style configuration files into Go structs
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-05 21:04:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1562840    
Bug Blocks:    

Description Dominik 'Rathann' Mierzejewski 2018-04-02 17:35:22 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-github-src-d-gcfg/golang-github-src-d-gcfg.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-src-d-gcfg/golang-github-src-d-gcfg-0-0.1.20180402gitf187355.fc27.src.rpm
Description:
Package gcfg reads "INI-style" text-based configuration files with "name=value"
pairs grouped into sections (gcfg files).

This is a fork of https://github.com/go-gcfg/gcfg .

Fedora Account System Username: rathann

Comment 1 Robert-André Mauchin 🐧 2018-04-02 22:27:05 UTC
 - Use the Release instead of the git commit: https://github.com/src-d/gcfg/releases

%global goipath  github.com/src-d/gcfg
Version: 1.3.0

%global common_description %{expand:
Package gcfg reads "INI-style" text-based configuration files with "name=value"
pairs grouped into sections (gcfg files).

This is a fork of https://github.com/go-gcfg/gcfg .}

%gometa

Name: %{goname}
Release: 1%{?dist}


   And the %changelog:

* Fri Mar 30 2018 Dominik Mierzejewski <dominik> - 1.3.0-1


 - Capitalize the summary:

Summary: Read INI-style configuration files into Go structs

Comment 2 Dominik 'Rathann' Mierzejewski 2018-04-05 11:27:37 UTC
Done:

Spec URL: https://rathann.fedorapeople.org/review/golang-github-src-d-gcfg/golang-github-src-d-gcfg.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-src-d-gcfg/golang-github-src-d-gcfg-1.3.0-1.fc27.src.rpm

* Thu Apr 05 2018 Dominik Mierzejewski <dominik> - 1.3.0-1
- use the release rather than the corresponding git commit

Comment 3 Robert-André Mauchin 🐧 2018-04-05 11:52:45 UTC
 - Capitalize the summary:

Summary: Read INI-style configuration files into Go structs


Package otherwise approved.

Comment 4 Dominik 'Rathann' Mierzejewski 2018-04-05 12:56:02 UTC
Right, will fix the Summary when importing. Thanks for the review!

Comment 5 Gwyn Ciesla 2018-04-05 13:02:14 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-src-d-gcfg

Comment 6 Dominik 'Rathann' Mierzejewski 2018-04-05 21:04:24 UTC
Imported and built for rawhide.