Bug 1563188

Summary: devel RPM file name gets truncated when using %{goname}
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: go-srpm-macrosAssignee: Jan Chaloupka <jchaloup>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: jcajka, jchaloup, nicolas.mailhot, quantum.analyst, vbatts
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-26 14:21:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1584973    

Description Dominik 'Rathann' Mierzejewski 2018-04-03 11:48:22 UTC 
Description of problem:
When building golang-gopkg-src-d-git package, the resulting -devel RPM's name gets truncated.

Version-Release number of selected component (if applicable):
go-srpm-macros-2-16.fc29.noarch

How reproducible:
Always.

Steps to Reproduce:
1. cd to your SPECS directory
2. curl -O https://rathann.fedorapeople.org/review/golang-gopkg-src-d-git/golang-gopkg-src-d-git.spec
3. rpmbuild -bb golang-gopkg-src-d-git.spec

Actual results:
[...]
Wrote: /builddir/build/RPMS/golang-gopkg-src-d-4-devel-4.2.0-1.fc29.noarch.rpm
[...]

Expected results:
[...]
Wrote: /builddir/build/RPMS/golang-gopkg-src-d-git-4-devel-4.2.0-1.fc29.noarch.rpm
[...]

Additional info:
Not using %{goname} macro in package names works:

%global api             4
[...]
%package %{api}-devel
[...]
%description %{api}-devel
[...]
%files %{api}-devel -f devel.file-list

Compare:
https://rathann.fedorapeople.org/review/golang-gopkg-src-d-git/golang-gopkg-src-d-git.spec.no-goname
Comment 1 Jan Chaloupka 2018-04-03 11:56:15 UTC 
Nicolas, can you check it out?
Comment 2 Nicolas Mailhot 2018-04-04 08:06:47 UTC 
That is caused by overly broad .git suffix cleanup logic. I’ll try to make it more selective
Comment 3 Jan Chaloupka 2018-05-10 10:28:45 UTC 
https://github.com/gofed/go-macros/pull/44
Comment 4 Nicolas Mailhot 2018-05-11 14:29:39 UTC 
Thanks for the merge!
Comment 5 Jan Kurik 2018-08-14 11:14:13 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.
Comment 6 Elliott Sales de Andrade 2018-08-15 05:09:14 UTC 
Any timeline on when this can be built?
Comment 7 Elliott Sales de Andrade 2018-08-23 09:49:21 UTC 
Ping again? The Beta Freeze is just around the corner.
Comment 8 Jan Chaloupka 2018-08-26 14:21:05 UTC 
Rawhide build with the fix was built by the end of June.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=1086648