Bug 1584973 - Review Request: golang-github-git-lfs-netrc - A Golang package for reading and writing netrc files
Summary: Review Request: golang-github-git-lfs-netrc - A Golang package for reading an...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1563188
Blocks: 1583642
TreeView+ depends on / blocked
 
Reported: 2018-06-01 05:08 UTC by Elliott Sales de Andrade
Modified: 2018-09-06 03:10 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-09-06 02:32:16 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-06-01 05:08:13 UTC
Spec URL: https://qulogic.fedorapeople.org//golang-github-git-lfs-go-netrc.spec
SRPM URL: https://qulogic.fedorapeople.org//golang-github-git-lfs-go-netrc-0-0.1.20180525gite0e9ca4.fc27.src.rpm

Description:
A Golang package for reading and writing netrc files. This package
can parse netrc files, make changes to them, and then serialize them
back to netrc format, while preserving any whitespace that was
present in the source file.

Comment 1 Elliott Sales de Andrade 2018-06-01 05:08:17 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=27338818

Comment 2 Robert-André Mauchin 🐧 2018-06-01 11:37:43 UTC
Could you use the new Golang packaging guidelines? https://fedoraproject.org/wiki/More_Go_packaging

See examples here: https://eclipseo.fedorapeople.org/golang/

Update gofed with updates-testing to get the new one which generates SPEC according to the new guidelines:

sudo dnf update gofed --enablerepo=updates-testing

Comment 3 Elliott Sales de Andrade 2018-06-06 08:20:02 UTC
The %{goname} removes go- and git- from the name; I understand the former, but why the latter? Is that really a big problem with Go packages?

Comment 4 Robert-André Mauchin 🐧 2018-06-08 23:22:58 UTC
I don't know actually, you should ask nim or jchaloup at https://github.com/gofed/go-macros/issues

Comment 5 Elliott Sales de Andrade 2018-08-25 07:32:28 UTC
I added a little hack to make it produce the correct name:

Spec URL: https://qulogic.fedorapeople.org/golang-github-git-lfs-netrc.spec
SRPM URL: https://qulogic.fedorapeople.org/golang-github-git-lfs-netrc-0-0.1.20180601gite0e9ca4.fc28.src.rpm

Comment 6 Robert-André Mauchin 🐧 2018-08-25 12:50:02 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 7 Gwyn Ciesla 2018-08-27 12:35:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-git-lfs-netrc

Comment 8 Fedora Update System 2018-08-27 22:43:24 UTC
golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8816410875

Comment 9 Fedora Update System 2018-08-27 22:43:40 UTC
golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1916746967

Comment 10 Fedora Update System 2018-08-28 10:51:54 UTC
golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8816410875

Comment 11 Fedora Update System 2018-08-28 11:39:37 UTC
golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1916746967

Comment 12 Fedora Update System 2018-09-06 02:32:16 UTC
golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2018-09-06 03:10:28 UTC
golang-github-git-lfs-netrc-0-0.1.20180827gite0e9ca4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.