Bug 1563847

Summary:	Review Request: nodejs-add-stream - Append the contents of one stream onto another
Product:	[Fedora] Fedora	Reporter:	Jared Smith <jsmith.fedora>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-24 16:43:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	956806

Description Jared Smith 2018-04-04 21:11:50 UTC

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-add-stream/nodejs-add-stream.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-add-stream/nodejs-add-stream-1.0.0-1.fc29.src.rpm
Description: Append the contents of one stream onto another
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-04-05 07:26:53 UTC

 - Tests fail because:

BUILDSTDERR: Error: Cannot find module 'chai'

   Add:

BuildRequires:	npm(chai)



 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 2 Jared Smith 2018-04-05 14:42:00 UTC

Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/5623.

Comment 3 Gwyn Ciesla 2018-04-05 14:51:55 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-add-stream

Comment 4 Jared Smith 2018-04-24 16:43:50 UTC

Packaged in Rawhide, closing this issue