Bug 1563847 - Review Request: nodejs-add-stream - Append the contents of one stream onto another
Summary: Review Request: nodejs-add-stream - Append the contents of one stream onto an...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2018-04-04 21:11 UTC by Jared Smith
Modified: 2018-04-24 16:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-04-24 16:43:50 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2018-04-04 21:11:50 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-add-stream/nodejs-add-stream.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-add-stream/nodejs-add-stream-1.0.0-1.fc29.src.rpm
Description: Append the contents of one stream onto another
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-04-05 07:26:53 UTC
 - Tests fail because:

BUILDSTDERR: Error: Cannot find module 'chai'

   Add:

BuildRequires:	npm(chai)



 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 2 Jared Smith 2018-04-05 14:42:00 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/5623.

Comment 3 Gwyn Ciesla 2018-04-05 14:51:55 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-add-stream

Comment 4 Jared Smith 2018-04-24 16:43:50 UTC
Packaged in Rawhide, closing this issue


Note You need to log in before you can comment on or make changes to this bug.