Bug 1563849

Summary: Review Request: nodejs-conventional-changelog-jshint - A conventional-changelog jshint preset
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-23 14:45:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806    

Comment 1 Robert-André Mauchin 🐧 2018-04-05 07:56:41 UTC
 - %{__nodejs} -e 'require("./")' fail because:

BUILDSTDERR: Error: Cannot find module 'compare-func'

   Add:

BuildRequires:	npm(compare-func)



 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 2 Jared Smith 2018-04-05 14:48:31 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/5624.

Comment 3 Gwyn Ciesla 2018-04-05 14:53:21 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-conventional-changelog-jshint

Comment 4 Jared Smith 2018-04-23 14:45:23 UTC
Packaged in Rawhide, closing this issue