Bug 1563849 - Review Request: nodejs-conventional-changelog-jshint - A conventional-changelog jshint preset
Summary: Review Request: nodejs-conventional-changelog-jshint - A conventional-changel...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2018-04-04 21:18 UTC by Jared Smith
Modified: 2018-04-23 14:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-23 14:45:23 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2018-04-04 21:18:42 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-changelog-jshint/nodejs-conventional-changelog-jshint.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-changelog-jshint/nodejs-conventional-changelog-jshint-0.3.8-1.fc29.src.rpm
Description: A conventional-changelog jshint preset
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2018-04-05 07:56:41 UTC 
 - %{__nodejs} -e 'require("./")' fail because:

BUILDSTDERR: Error: Cannot find module 'compare-func'

   Add:

BuildRequires:	npm(compare-func)



 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.
Comment 2 Jared Smith 2018-04-05 14:48:31 UTC 
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/5624.
Comment 3 Gwyn Ciesla 2018-04-05 14:53:21 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-conventional-changelog-jshint
Comment 4 Jared Smith 2018-04-23 14:45:23 UTC 
Packaged in Rawhide, closing this issue
Note You need to log in before you can comment on or make changes to this bug.