Bug 1564146
Summary: | cpuflags hook should use sap_agent predefined property | ||
---|---|---|---|
Product: | [oVirt] ovirt-engine | Reporter: | Michal Skrivanek <michal.skrivanek> |
Component: | BLL.Virt | Assignee: | Martin Polednik <mpoledni> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Liran Rotenberg <lrotenbe> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4.2.2 | CC: | avijayku, bugs |
Target Milestone: | ovirt-4.2.3 | Flags: | rule-engine:
ovirt-4.2+
|
Target Release: | 4.2.3 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | ovirt-engine-4.2.3 | Doc Type: | If docs needed, set a value |
Doc Text: |
Previously, vdsm-hook-cpuflags required new custom property to add specified cpu flags to the host. For SAP workloads, the property had to carry special keyword "SAP". The previous behavior is preserved, but the SAP portion of the hook is now additionally triggered by setting "sap_agent" predefined property to "true".
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2018-05-10 06:31:23 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michal Skrivanek
2018-04-05 13:25:12 UTC
*** Bug 1563812 has been marked as a duplicate of this bug. *** So if I want to enable the cpuflags hook and also account for the specific SAP flags, I have to do both "cpuflags" -> "SAP" and "sap_agent" -> "true" under "VM" -> "Edit" -> "Custom Properties"? In other words, it won't suffice to set only one of these properties? It is sufficient, if the hook is installed, to only set "sap_agent". If additional cpu flags are specified (or some of them are duplicated), the hook calculates the proper subset to add to the VM. Verified on: vdsm-4.20.26-1.el7ev.x86_64 vdsm-hook-cpuflags-4.20.26-1.el7ev.noarch ovirt-engine-4.2.3.2-0.1.el7.noarch Steps: 1. install vdsm-hook-cpuflags on the host 2. create a vm. 3. set the vm custom properties with sap_agent - true. 4. start the vm. Result: The vm started on the desired host in virsh dumpxml it shows: <ovirt-vm:custom> <ovirt-vm:sap_agent>true</ovirt-vm:sap_agent> </ovirt-vm:custom> and from vdsm-client VM getInfo: "custom": { "sap_agent": "true" }, under devices: "iface": "ide", "name": "hdc", "vm_custom": { "sap_agent": "true" }, "name": "vda", "vm_custom": { "sap_agent": "true" }, "name": "vdzz", "vm_custom": { "sap_agent": "true" }, This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |