Bug 1564146 - cpuflags hook should use sap_agent predefined property
Summary: cpuflags hook should use sap_agent predefined property
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.2.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.3
: 4.2.3
Assignee: Martin Polednik
QA Contact: Liran Rotenberg
URL:
Whiteboard:
: 1563812 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-05 13:25 UTC by Michal Skrivanek
Modified: 2018-05-10 06:31 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-4.2.3
Doc Type: If docs needed, set a value
Doc Text:
Previously, vdsm-hook-cpuflags required new custom property to add specified cpu flags to the host. For SAP workloads, the property had to carry special keyword "SAP". The previous behavior is preserved, but the SAP portion of the hook is now additionally triggered by setting "sap_agent" predefined property to "true".
Clone Of:
Environment:
Last Closed: 2018-05-10 06:31:23 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 89874 0 master MERGED activate cpuflags hooks' SAP flag when sap_agent is specified 2018-04-06 12:05:47 UTC
oVirt gerrit 90221 0 ovirt-4.2 MERGED activate cpuflags hooks' SAP flag when sap_agent is specified 2018-04-12 13:48:00 UTC

Description Michal Skrivanek 2018-04-05 13:25:12 UTC
vdsm-hook-cpuflags hook is sort-of-supported (the hook is, not a random flag of course) and so it does deserve a predefined property in webadmin

Alternatively, we can keep it the way it is and just update doc of that hook (it doesn't have a README today at all)

Comment 2 Michal Skrivanek 2018-04-09 13:23:59 UTC
*** Bug 1563812 has been marked as a duplicate of this bug. ***

Comment 3 Anaga Vijaykumar 2018-04-12 13:46:23 UTC
So if I want to enable the cpuflags hook and also account for the specific SAP flags, I have to do both "cpuflags" -> "SAP" and "sap_agent" -> "true" under "VM" -> "Edit" -> "Custom Properties"? In other words, it won't suffice to set only one of these properties?

Comment 4 Martin Polednik 2018-04-12 13:49:58 UTC
It is sufficient, if the hook is installed, to only set "sap_agent". If additional cpu flags are specified (or some of them are duplicated), the hook calculates the proper subset to add to the VM.

Comment 5 Liran Rotenberg 2018-04-24 11:22:47 UTC
Verified on:
vdsm-4.20.26-1.el7ev.x86_64
vdsm-hook-cpuflags-4.20.26-1.el7ev.noarch
ovirt-engine-4.2.3.2-0.1.el7.noarch

Steps:
1. install vdsm-hook-cpuflags on the host
2. create a vm.
3. set the vm custom properties with sap_agent - true.
4. start the vm.

Result:
The vm started on the desired host in virsh dumpxml it shows:
<ovirt-vm:custom>
        <ovirt-vm:sap_agent>true</ovirt-vm:sap_agent>
</ovirt-vm:custom>

and from vdsm-client VM getInfo:
"custom": {
        "sap_agent": "true"
    }, 
under devices:
"iface": "ide", 
            "name": "hdc", 
            "vm_custom": {
                "sap_agent": "true"
            }, 
"name": "vda", 
            "vm_custom": {
                "sap_agent": "true"
            }, 
"name": "vdzz", 
            "vm_custom": {
                "sap_agent": "true"
            },

Comment 6 Sandro Bonazzola 2018-05-10 06:31:23 UTC
This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.