Bug 1564673

Summary: atomic fails to install system containers when selinux is disabled
Product: Red Hat Enterprise Linux 7 Reporter: Steve Milner <smilner>
Component: atomicAssignee: Giuseppe Scrivano <gscrivan>
Status: CLOSED ERRATA QA Contact: atomic-bugs <atomic-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.4CC: bbaude, ddarrah, dornelas, dwalsh, fkluknav, jspanko, lsm5, rrajaram, sakulkar, weshen, ypu
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: atomic-1.22.1-4.git1895984.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-26 18:39:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1186913, 1561841    

Description Steve Milner 2018-04-06 20:40:38 UTC 
Description of problem:
When SELinux is set to disabled (not permissive or enforcing) the atomic command throws a stack trace attempting to install a new system container.

Version-Release number of selected component (if applicable):
1.22.1

How reproducible:
When SELinux is disabled, every time.

Steps to Reproduce:
1. Fully disable SELinux
2. Restart the machine
3. atomic install --system --system-package=no registry.access.redhat.com/rhel7/etcd

Actual results:
Traceback (most recent call last):
  File "/usr/bin/atomic", line 185, in <module>
    sys.exit(_func())
  File "/usr/lib/python2.7/site-packages/Atomic/install.py", line 134, in install
    return be.install(self.image, self.name)
  File "/usr/lib/python2.7/site-packages/Atomic/backends/_ostree.py", line 128, in install
    return self.syscontainers.install(image, name)
  File "/usr/lib/python2.7/site-packages/Atomic/syscontainers.py", line 578, in install
    return_value = self._install(image, name)
  File "/usr/lib/python2.7/site-packages/Atomic/syscontainers.py", line 706, in _install
    self._checkout_wrapper(repo, name, image, 0, SystemContainers.CHECKOUT_MODE_INSTALL, values=values, remote=self.args.remote, system_package=self.args.system_package)
  File "/usr/lib/python2.7/site-packages/Atomic/syscontainers.py", line 817, in _checkout_wrapper
    return self._checkout(repo, options)
  File "/usr/lib/python2.7/site-packages/Atomic/syscontainers.py", line 848, in _checkout
    raise e
OSError: [Errno 22] Invalid argument


Expected results:
Successful installation

Additional info:
This was reported by a user on RHEL 7.4 on freenode.

A fix already exists: https://github.com/projectatomic/atomic/commit/119f1236bb08b079241b6ad64230e58fec217f26
Comment 2 Giuseppe Scrivano 2018-04-26 20:52:09 UTC 
this was fixed upstream:

https://github.com/projectatomic/atomic/pull/1213
Comment 4 Lokesh Mandvekar 2018-06-14 17:30:35 UTC 
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=705025
Comment 6 Edward Shen 2018-06-15 04:09:37 UTC 
Tested with atomic-1.22.1-4.git1895984.el7, this issue is fixed.
Comment 8 errata-xmlrpc 2018-06-26 18:39:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2033