Bug 1568372
Summary: | Submit/Cancel buttons are not displayed on custom button dialogs for some service types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Peter McGowan <pmcgowan> | ||||||
Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Niyaz Akhtar Ansari <nansari> | ||||||
Severity: | high | Docs Contact: | |||||||
Priority: | high | ||||||||
Version: | 5.9.0 | CC: | cbolz, cpelland, hkataria, lavenel, mpovolny, nansari, ngupta, obarenbo, tfitzger | ||||||
Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||||
Target Release: | 5.10.0 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | |||||||||
: | 1578954 (view as bug list) | Environment: | |||||||
Last Closed: | 2019-02-11 13:59:17 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1578954 | ||||||||
Attachments: |
|
Description
Peter McGowan
2018-04-17 11:20:35 UTC
Created attachment 1423000 [details]
Screenshot button dialog VM provision service type
Created attachment 1423001 [details]
Screenshot button dialog Ansible playbook service type
*** Bug 1568371 has been marked as a duplicate of this bug. *** New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/d5da59f6214dd06494849cf8b55cf7efb9a72023 commit d5da59f6214dd06494849cf8b55cf7efb9a72023 Author: Harpreet Kataria <hkataria> AuthorDate: Wed Apr 18 12:44:51 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Apr 18 12:44:51 2018 -0400 Render new dialog runner for all service types. Also no need to show Save/reset/cancel buttons at the bottom of screen causing double set of buttons on screen, new dialog runner renders it's own form buttons. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568372 app/controllers/service_controller.rb | 28 +- app/services/dialog_local_service.rb | 1 + 2 files changed, 12 insertions(+), 17 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/23889eaafdfe160111987013172e2e23473df3f9 commit 23889eaafdfe160111987013172e2e23473df3f9 Author: Harpreet Kataria <hkataria> AuthorDate: Wed Apr 18 13:50:13 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Apr 18 13:50:13 2018 -0400 Adjusted target_type value and added spec test. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568372 app/services/dialog_local_service.rb | 2 + spec/services/dialog_local_service_spec.rb | 18 + 2 files changed, 20 insertions(+) *** Bug 1595051 has been marked as a duplicate of this bug. *** *** Bug 1595051 has been marked as a duplicate of this bug. *** Verified in Version 5.10.0.14.20180831154906_2f9a1dd |