Bug 157106
Summary: | bmptopnm reports filenames as "Standard Input" when reporting read errors | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Costanzo <david_costanzo> | ||||
Component: | netpbm | Assignee: | Jindrich Novy <jnovy> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Ben Levenson <benl> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 4 | CC: | pknirsch | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i686 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 10.27-2 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-05-09 10:27:35 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
David Costanzo
2005-05-06 21:13:28 UTC
Created attachment 114100 [details]
proposed patch
The fix is to inverted the condition in an if statement that used strcmp().
I did a quick grep of the tree too look for other bugs like this one. Other
other uses look good. Except there was one suspicious usage in
converter/other/pnmtojpeg.c:
if (strcmp(cmdline_p->input_filespec, "=") == 0 &&
It should probably be:
if (strcmp(cmdline_p->input_filespec, "-") == 0 &&
I will report this as a separate bug.
Oops! I forgot to include the package version: netpbm-progs-10.27-1 Fixed. Thanks. |